Skip to content

Commit 1f54391

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: aardvark: Assert PERST# when unbinding driver
Put the PCIe card into reset by asserting PERST# signal when unbinding driver. It doesn't make sense to leave the card working if it can't communicate with the host. This should also save some power. Link: https://lore.kernel.org/r/20211130172913.9727-10-kabel@kernel.org Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Marek Behún <kabel@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 2f040a1 commit 1f54391

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/pci/controller/pci-aardvark.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1737,6 +1737,10 @@ static int advk_pcie_remove(struct platform_device *pdev)
17371737
/* Free config space for emulated root bridge */
17381738
pci_bridge_emul_cleanup(&pcie->bridge);
17391739

1740+
/* Assert PERST# signal which prepares PCIe card for power down */
1741+
if (pcie->reset_gpio)
1742+
gpiod_set_value_cansleep(pcie->reset_gpio, 1);
1743+
17401744
/* Disable outbound address windows mapping */
17411745
for (i = 0; i < OB_WIN_COUNT; i++)
17421746
advk_pcie_disable_ob_win(pcie, i);

0 commit comments

Comments
 (0)