Skip to content

Commit 1fb815b

Browse files
martenlirichardweinberger
authored andcommitted
ubifs: Free memory for tmpfile name
When opening a ubifs tmpfile on an encrypted directory, function fscrypt_setup_filename allocates memory for the name that is to be stored in the directory entry, but after the name has been copied to the directory entry inode, the memory is not freed. When running kmemleak on it we see that it is registered as a leak. The report below is triggered by a simple program 'tmpfile' just opening a tmpfile: unreferenced object 0xffff88810178f380 (size 32): comm "tmpfile", pid 509, jiffies 4294934744 (age 1524.742s) backtrace: __kmem_cache_alloc_node __kmalloc fscrypt_setup_filename ubifs_tmpfile vfs_tmpfile path_openat Free this memory after it has been copied to the inode. Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> Cc: stable@vger.kernel.org Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent 31a149d commit 1fb815b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

fs/ubifs/dir.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,7 @@ static int ubifs_tmpfile(struct mnt_idmap *idmap, struct inode *dir,
492492
unlock_2_inodes(dir, inode);
493493

494494
ubifs_release_budget(c, &req);
495+
fscrypt_free_filename(&nm);
495496

496497
return finish_open_simple(file, 0);
497498

0 commit comments

Comments
 (0)