Skip to content

Commit 1fcb712

Browse files
dhowellsbrauner
authored andcommitted
sound: Fix snd_pcm_readv()/writev() to use iov access functions
Fix snd_pcm_readv()/writev() to use iov access functions rather than poking at the iov_iter internals directly. Signed-off-by: David Howells <dhowells@redhat.com> Link: https://lore.kernel.org/r/20230925120309.1731676-4-dhowells@redhat.com Reviewed-by: Jaroslav Kysela <perex@perex.cz> Reviewed-by: Takashi Iwai <tiwai@suse.de> cc: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> cc: Jens Axboe <axboe@kernel.dk> cc: Suren Baghdasaryan <surenb@google.com> cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> cc: alsa-devel@alsa-project.org Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 066baf9 commit 1fcb712

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sound/core/pcm_native.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3527,7 +3527,7 @@ static ssize_t snd_pcm_readv(struct kiocb *iocb, struct iov_iter *to)
35273527
if (runtime->state == SNDRV_PCM_STATE_OPEN ||
35283528
runtime->state == SNDRV_PCM_STATE_DISCONNECTED)
35293529
return -EBADFD;
3530-
if (!to->user_backed)
3530+
if (!user_backed_iter(to))
35313531
return -EINVAL;
35323532
if (to->nr_segs > 1024 || to->nr_segs != runtime->channels)
35333533
return -EINVAL;
@@ -3567,7 +3567,7 @@ static ssize_t snd_pcm_writev(struct kiocb *iocb, struct iov_iter *from)
35673567
if (runtime->state == SNDRV_PCM_STATE_OPEN ||
35683568
runtime->state == SNDRV_PCM_STATE_DISCONNECTED)
35693569
return -EBADFD;
3570-
if (!from->user_backed)
3570+
if (!user_backed_iter(from))
35713571
return -EINVAL;
35723572
if (from->nr_segs > 128 || from->nr_segs != runtime->channels ||
35733573
!frame_aligned(runtime, iov->iov_len))

0 commit comments

Comments
 (0)