Skip to content

Commit 20487cc

Browse files
Harshitha Premkvalo
authored andcommitted
wifi: ath11k: add peer mac information in failure cases
During reo command failure, the peer mac detail for which the reo command was not successful is unknown. Hence, to improve the debuggability, add the peer mac information in the failure cases which would be useful during multi client cases. Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1 Signed-off-by: Sathishkumar Muruganandam <quic_murugana@quicinc.com> Signed-off-by: Harshitha Prem <quic_hprem@quicinc.com> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Link: https://lore.kernel.org/r/20230403182420.23375-4-quic_hprem@quicinc.com
1 parent a8ae833 commit 20487cc

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

  • drivers/net/wireless/ath/ath11k

drivers/net/wireless/ath/ath11k/dp_rx.c

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,8 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
10091009

10101010
peer = ath11k_peer_find(ab, vdev_id, peer_mac);
10111011
if (!peer) {
1012-
ath11k_warn(ab, "failed to find the peer to set up rx tid\n");
1012+
ath11k_warn(ab, "failed to find the peer %pM to set up rx tid\n",
1013+
peer_mac);
10131014
spin_unlock_bh(&ab->base_lock);
10141015
return -ENOENT;
10151016
}
@@ -1022,16 +1023,17 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
10221023
ba_win_sz, ssn, true);
10231024
spin_unlock_bh(&ab->base_lock);
10241025
if (ret) {
1025-
ath11k_warn(ab, "failed to update reo for rx tid %d\n", tid);
1026+
ath11k_warn(ab, "failed to update reo for peer %pM rx tid %d\n: %d",
1027+
peer_mac, tid, ret);
10261028
return ret;
10271029
}
10281030

10291031
ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id,
10301032
peer_mac, paddr,
10311033
tid, 1, ba_win_sz);
10321034
if (ret)
1033-
ath11k_warn(ab, "failed to send wmi command to update rx reorder queue, tid :%d (%d)\n",
1034-
tid, ret);
1035+
ath11k_warn(ab, "failed to send wmi rx reorder queue for peer %pM tid %d: %d\n",
1036+
peer_mac, tid, ret);
10351037
return ret;
10361038
}
10371039

@@ -1064,6 +1066,8 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
10641066
ret = dma_mapping_error(ab->dev, paddr);
10651067
if (ret) {
10661068
spin_unlock_bh(&ab->base_lock);
1069+
ath11k_warn(ab, "failed to setup dma map for peer %pM rx tid %d: %d\n",
1070+
peer_mac, tid, ret);
10671071
goto err_mem_free;
10681072
}
10691073

@@ -1077,8 +1081,8 @@ int ath11k_peer_rx_tid_setup(struct ath11k *ar, const u8 *peer_mac, int vdev_id,
10771081
ret = ath11k_wmi_peer_rx_reorder_queue_setup(ar, vdev_id, peer_mac,
10781082
paddr, tid, 1, ba_win_sz);
10791083
if (ret) {
1080-
ath11k_warn(ar->ab, "failed to setup rx reorder queue, tid :%d (%d)\n",
1081-
tid, ret);
1084+
ath11k_warn(ar->ab, "failed to setup rx reorder queue for peer %pM tid %d: %d\n",
1085+
peer_mac, tid, ret);
10821086
ath11k_dp_rx_tid_mem_free(ab, peer_mac, vdev_id, tid);
10831087
}
10841088

0 commit comments

Comments
 (0)