Skip to content

Commit 20c111d

Browse files
Uwe Kleine-Königlag-linaro
authored andcommitted
backlight: rt4831-backlight: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230308073945.2336302-13-u.kleine-koenig@pengutronix.de
1 parent ea379bc commit 20c111d

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/backlight/rt4831-backlight.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,15 +203,13 @@ static int rt4831_bl_probe(struct platform_device *pdev)
203203
return 0;
204204
}
205205

206-
static int rt4831_bl_remove(struct platform_device *pdev)
206+
static void rt4831_bl_remove(struct platform_device *pdev)
207207
{
208208
struct rt4831_priv *priv = platform_get_drvdata(pdev);
209209
struct backlight_device *bl_dev = priv->bl;
210210

211211
bl_dev->props.brightness = 0;
212212
backlight_update_status(priv->bl);
213-
214-
return 0;
215213
}
216214

217215
static const struct of_device_id __maybe_unused rt4831_bl_of_match[] = {
@@ -226,7 +224,7 @@ static struct platform_driver rt4831_bl_driver = {
226224
.of_match_table = rt4831_bl_of_match,
227225
},
228226
.probe = rt4831_bl_probe,
229-
.remove = rt4831_bl_remove,
227+
.remove_new = rt4831_bl_remove,
230228
};
231229
module_platform_driver(rt4831_bl_driver);
232230

0 commit comments

Comments
 (0)