Skip to content

Commit 20c2dbf

Browse files
vsyrjalajnikula
vsyrjala
authored and
jnikula
committed
drm/i915: Skip some timing checks on BXT/GLK DSI transcoders
Apparently some BXT/GLK systems have DSI panels whose timings don't agree with the normal cpu transcoder hblank>=32 limitation. This is perhaps fine as there are no specific hblank/etc. limits listed for the BXT/GLK DSI transcoders. Move those checks out from the global intel_mode_valid() into into connector specific .mode_valid() hooks, skipping BXT/GLK DSI connectors. We'll leave the basic [hv]display/[hv]total checks in intel_mode_valid() as those seem like sensible upper limits regardless of the transcoder used. Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9720 Fixes: 8f4b106 ("drm/i915: Check some transcoder timing minimum limits") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231127145028.4899-1-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com> (cherry picked from commit e0ef2da) Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent 96d7e79 commit 20c2dbf

12 files changed

Lines changed: 79 additions & 3 deletions

File tree

‎drivers/gpu/drm/i915/display/icl_dsi.c‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,6 +1440,13 @@ static void gen11_dsi_post_disable(struct intel_atomic_state *state,
14401440
static enum drm_mode_status gen11_dsi_mode_valid(struct drm_connector *connector,
14411441
struct drm_display_mode *mode)
14421442
{
1443+
struct drm_i915_private *i915 = to_i915(connector->dev);
1444+
enum drm_mode_status status;
1445+
1446+
status = intel_cpu_transcoder_mode_valid(i915, mode);
1447+
if (status != MODE_OK)
1448+
return status;
1449+
14431450
/* FIXME: DSC? */
14441451
return intel_dsi_mode_valid(connector, mode);
14451452
}

‎drivers/gpu/drm/i915/display/intel_crt.c‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,13 @@ intel_crt_mode_valid(struct drm_connector *connector,
348348
struct drm_device *dev = connector->dev;
349349
struct drm_i915_private *dev_priv = to_i915(dev);
350350
int max_dotclk = dev_priv->max_dotclk_freq;
351+
enum drm_mode_status status;
351352
int max_clock;
352353

354+
status = intel_cpu_transcoder_mode_valid(dev_priv, mode);
355+
if (status != MODE_OK)
356+
return status;
357+
353358
if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
354359
return MODE_NO_DBLESCAN;
355360

‎drivers/gpu/drm/i915/display/intel_display.c‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7869,6 +7869,16 @@ enum drm_mode_status intel_mode_valid(struct drm_device *dev,
78697869
mode->vtotal > vtotal_max)
78707870
return MODE_V_ILLEGAL;
78717871

7872+
return MODE_OK;
7873+
}
7874+
7875+
enum drm_mode_status intel_cpu_transcoder_mode_valid(struct drm_i915_private *dev_priv,
7876+
const struct drm_display_mode *mode)
7877+
{
7878+
/*
7879+
* Additional transcoder timing limits,
7880+
* excluding BXT/GLK DSI transcoders.
7881+
*/
78727882
if (DISPLAY_VER(dev_priv) >= 5) {
78737883
if (mode->hdisplay < 64 ||
78747884
mode->htotal - mode->hdisplay < 32)

‎drivers/gpu/drm/i915/display/intel_display.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,9 @@ enum drm_mode_status
403403
intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
404404
const struct drm_display_mode *mode,
405405
bool bigjoiner);
406+
enum drm_mode_status
407+
intel_cpu_transcoder_mode_valid(struct drm_i915_private *i915,
408+
const struct drm_display_mode *mode);
406409
enum phy intel_port_to_phy(struct drm_i915_private *i915, enum port port);
407410
bool is_trans_port_sync_mode(const struct intel_crtc_state *state);
408411
bool is_trans_port_sync_master(const struct intel_crtc_state *state);

‎drivers/gpu/drm/i915/display/intel_dp.c‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,6 +1172,10 @@ intel_dp_mode_valid(struct drm_connector *_connector,
11721172
enum drm_mode_status status;
11731173
bool dsc = false, bigjoiner = false;
11741174

1175+
status = intel_cpu_transcoder_mode_valid(dev_priv, mode);
1176+
if (status != MODE_OK)
1177+
return status;
1178+
11751179
if (mode->flags & DRM_MODE_FLAG_DBLCLK)
11761180
return MODE_H_ILLEGAL;
11771181

‎drivers/gpu/drm/i915/display/intel_dp_mst.c‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -959,6 +959,10 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
959959
return 0;
960960
}
961961

962+
*status = intel_cpu_transcoder_mode_valid(dev_priv, mode);
963+
if (*status != MODE_OK)
964+
return 0;
965+
962966
if (mode->flags & DRM_MODE_FLAG_DBLSCAN) {
963967
*status = MODE_NO_DBLESCAN;
964968
return 0;

‎drivers/gpu/drm/i915/display/intel_dvo.c‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,11 +217,17 @@ intel_dvo_mode_valid(struct drm_connector *_connector,
217217
struct drm_display_mode *mode)
218218
{
219219
struct intel_connector *connector = to_intel_connector(_connector);
220+
struct drm_i915_private *i915 = to_i915(connector->base.dev);
220221
struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
221222
const struct drm_display_mode *fixed_mode =
222223
intel_panel_fixed_mode(connector, mode);
223224
int max_dotclk = to_i915(connector->base.dev)->max_dotclk_freq;
224225
int target_clock = mode->clock;
226+
enum drm_mode_status status;
227+
228+
status = intel_cpu_transcoder_mode_valid(i915, mode);
229+
if (status != MODE_OK)
230+
return status;
225231

226232
if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
227233
return MODE_NO_DBLESCAN;

‎drivers/gpu/drm/i915/display/intel_hdmi.c‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1983,6 +1983,10 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
19831983
bool ycbcr_420_only;
19841984
enum intel_output_format sink_format;
19851985

1986+
status = intel_cpu_transcoder_mode_valid(dev_priv, mode);
1987+
if (status != MODE_OK)
1988+
return status;
1989+
19861990
if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
19871991
clock *= 2;
19881992

‎drivers/gpu/drm/i915/display/intel_lvds.c‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,11 +389,16 @@ intel_lvds_mode_valid(struct drm_connector *_connector,
389389
struct drm_display_mode *mode)
390390
{
391391
struct intel_connector *connector = to_intel_connector(_connector);
392+
struct drm_i915_private *i915 = to_i915(connector->base.dev);
392393
const struct drm_display_mode *fixed_mode =
393394
intel_panel_fixed_mode(connector, mode);
394395
int max_pixclk = to_i915(connector->base.dev)->max_dotclk_freq;
395396
enum drm_mode_status status;
396397

398+
status = intel_cpu_transcoder_mode_valid(i915, mode);
399+
if (status != MODE_OK)
400+
return status;
401+
397402
if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
398403
return MODE_NO_DBLESCAN;
399404

‎drivers/gpu/drm/i915/display/intel_sdvo.c‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1921,13 +1921,19 @@ static enum drm_mode_status
19211921
intel_sdvo_mode_valid(struct drm_connector *connector,
19221922
struct drm_display_mode *mode)
19231923
{
1924+
struct drm_i915_private *i915 = to_i915(connector->dev);
19241925
struct intel_sdvo *intel_sdvo = intel_attached_sdvo(to_intel_connector(connector));
19251926
struct intel_sdvo_connector *intel_sdvo_connector =
19261927
to_intel_sdvo_connector(connector);
1927-
int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
19281928
bool has_hdmi_sink = intel_has_hdmi_sink(intel_sdvo_connector, connector->state);
1929+
int max_dotclk = i915->max_dotclk_freq;
1930+
enum drm_mode_status status;
19291931
int clock = mode->clock;
19301932

1933+
status = intel_cpu_transcoder_mode_valid(i915, mode);
1934+
if (status != MODE_OK)
1935+
return status;
1936+
19311937
if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
19321938
return MODE_NO_DBLESCAN;
19331939

0 commit comments

Comments
 (0)