Skip to content

Commit 20c4079

Browse files
lumaggregkh
authored andcommitted
misc: fastrpc: restrict user apps from sending kernel RPC messages
Verify that user applications are not using the kernel RPC message handle to restrict them from directly attaching to guest OS on the remote subsystem. This is a port of CVE-2019-2308 fix. Fixes: c68cfb7 ("misc: fastrpc: Add support for context Invoke method") Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Jonathan Marek <jonathan@marek.ca> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20210212192658.3476137-1-dmitry.baryshkov@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1201d68 commit 20c4079

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/misc/fastrpc.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -950,6 +950,11 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel,
950950
if (!fl->cctx->rpdev)
951951
return -EPIPE;
952952

953+
if (handle == FASTRPC_INIT_HANDLE && !kernel) {
954+
dev_warn_ratelimited(fl->sctx->dev, "user app trying to send a kernel RPC message (%d)\n", handle);
955+
return -EPERM;
956+
}
957+
953958
ctx = fastrpc_context_alloc(fl, kernel, sc, args);
954959
if (IS_ERR(ctx))
955960
return PTR_ERR(ctx);

0 commit comments

Comments
 (0)