Skip to content

Commit 2111c3c

Browse files
rddunlapChristian Brauner
authored andcommitted
namei: fix kernel-doc for struct renamedata and more
Fix kernel-doc warnings in namei.c: ../fs/namei.c:1149: warning: Excess function parameter 'dir_mode' description in 'may_create_in_sticky' ../fs/namei.c:1149: warning: Excess function parameter 'dir_uid' description in 'may_create_in_sticky' ../fs/namei.c:3396: warning: Function parameter or member 'open_flag' not described in 'vfs_tmpfile' ../fs/namei.c:3396: warning: Excess function parameter 'open_flags' description in 'vfs_tmpfile' ../fs/namei.c:4460: warning: Function parameter or member 'rd' not described in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'old_mnt_userns' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'old_dir' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'old_dentry' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'new_mnt_userns' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'new_dir' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'new_dentry' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'delegated_inode' description in 'vfs_rename' ../fs/namei.c:4460: warning: Excess function parameter 'flags' description in 'vfs_rename' Link: https://lore.kernel.org/r/20210216042929.8931-3-rdunlap@infradead.org Fixes: 9fe6145 ("namei: introduce struct renamedata") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: David Howells <dhowells@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Cc: Christian Brauner <christian.brauner@ubuntu.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
1 parent 59347d9 commit 2111c3c

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

fs/namei.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1122,8 +1122,7 @@ int may_linkat(struct user_namespace *mnt_userns, struct path *link)
11221122
* should be allowed, or not, on files that already
11231123
* exist.
11241124
* @mnt_userns: user namespace of the mount the inode was found from
1125-
* @dir_mode: mode bits of directory
1126-
* @dir_uid: owner of directory
1125+
* @nd: nameidata pathwalk data
11271126
* @inode: the inode of the file to open
11281127
*
11291128
* Block an O_CREAT open of a FIFO (or a regular file) when:
@@ -3381,7 +3380,7 @@ static int do_open(struct nameidata *nd,
33813380
* @mnt_userns: user namespace of the mount the inode was found from
33823381
* @dentry: pointer to dentry of the base directory
33833382
* @mode: mode of the new tmpfile
3384-
* @open_flags: flags
3383+
* @open_flag: flags
33853384
*
33863385
* Create a temporary file.
33873386
*
@@ -4406,14 +4405,7 @@ SYSCALL_DEFINE2(link, const char __user *, oldname, const char __user *, newname
44064405

44074406
/**
44084407
* vfs_rename - rename a filesystem object
4409-
* @old_mnt_userns: old user namespace of the mount the inode was found from
4410-
* @old_dir: parent of source
4411-
* @old_dentry: source
4412-
* @new_mnt_userns: new user namespace of the mount the inode was found from
4413-
* @new_dir: parent of destination
4414-
* @new_dentry: destination
4415-
* @delegated_inode: returns an inode needing a delegation break
4416-
* @flags: rename flags
4408+
* @rd: pointer to &struct renamedata info
44174409
*
44184410
* The caller must hold multiple mutexes--see lock_rename()).
44194411
*

0 commit comments

Comments
 (0)