Skip to content

Commit 211db0a

Browse files
namjaejeonAl Viro
authored andcommitted
ksmbd: remove internal.h include
Since vfs_path_lookup is exported, It should not be internal. Move vfs_path_lookup prototype in internal.h to linux/namei.h. Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent fe15c26 commit 211db0a

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

fs/internal.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ extern int finish_clean_context(struct fs_context *fc);
5959
*/
6060
extern int filename_lookup(int dfd, struct filename *name, unsigned flags,
6161
struct path *path, struct path *root);
62-
extern int vfs_path_lookup(struct dentry *, struct vfsmount *,
63-
const char *, unsigned int, struct path *);
6462
int do_rmdir(int dfd, struct filename *name);
6563
int do_unlinkat(int dfd, struct filename *name);
6664
int may_linkat(struct mnt_idmap *idmap, const struct path *link);

fs/ksmbd/vfs.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
#include <linux/sched/xacct.h>
2020
#include <linux/crc32c.h>
2121

22-
#include "../internal.h" /* for vfs_path_lookup */
23-
2422
#include "glob.h"
2523
#include "oplock.h"
2624
#include "connection.h"

include/linux/namei.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ extern struct dentry *kern_path_create(int, const char *, struct path *, unsigne
6363
extern struct dentry *user_path_create(int, const char __user *, struct path *, unsigned int);
6464
extern void done_path_create(struct path *, struct dentry *);
6565
extern struct dentry *kern_path_locked(const char *, struct path *);
66+
int vfs_path_lookup(struct dentry *, struct vfsmount *, const char *,
67+
unsigned int, struct path *);
6668

6769
extern struct dentry *try_lookup_one_len(const char *, struct dentry *, int);
6870
extern struct dentry *lookup_one_len(const char *, struct dentry *, int);

0 commit comments

Comments
 (0)