Skip to content

Commit 2122120

Browse files
LaurentiuM1234pH5
authored andcommitted
reset: imx8mp-audiomix: Drop unneeded macros
The macros defining the mask values for the EARC, EARC PHY resets, and the DSP RUN_STALL signal can be dropped as they are not and will not be used anywhere else except to set the value of the "mask" field from "struct imx8mp_reset_map". In this particular case, based on the name of the "mask" field, you can already deduce what these values are for, which is why defining macros for them doesn't offer any new information, nor does it help with the code readability. Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
1 parent 16de4c6 commit 2122120

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

drivers/reset/reset-imx8mp-audiomix.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
#include <dt-bindings/reset/imx8mp-reset-audiomix.h>
77

88
#include <linux/auxiliary_bus.h>
9+
#include <linux/bits.h>
910
#include <linux/device.h>
1011
#include <linux/io.h>
1112
#include <linux/module.h>
@@ -14,11 +15,7 @@
1415
#include <linux/reset-controller.h>
1516

1617
#define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200
17-
#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0)
18-
#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1)
19-
2018
#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108
21-
#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5)
2219

2320
struct imx8mp_reset_map {
2421
unsigned int offset;
@@ -29,17 +26,17 @@ struct imx8mp_reset_map {
2926
static const struct imx8mp_reset_map reset_map[] = {
3027
[IMX8MP_AUDIOMIX_EARC_RESET] = {
3128
.offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
32-
.mask = IMX8MP_AUDIOMIX_EARC_RESET_MASK,
29+
.mask = BIT(0),
3330
.active_low = true,
3431
},
3532
[IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {
3633
.offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
37-
.mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,
34+
.mask = BIT(1),
3835
.active_low = true,
3936
},
4037
[IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {
4138
.offset = IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,
42-
.mask = IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,
39+
.mask = BIT(5),
4340
.active_low = false,
4441
},
4542
};

0 commit comments

Comments
 (0)