Skip to content

Commit 2138c32

Browse files
krzkandersson
authored andcommitted
ARM: dts: qcom: ipq8064: move keys and leds out of soc node
GPIO keys and LEDs are not part of the SoC, so move them to top-level to fix dtbs_check warnings like: qcom-ipq8064-rb3011.dtb: soc: gpio-keys: {'compatible': ['gpio-keys'], ... should not be valid under {'type': 'object'} from schema $id: http://devicetree.org/schemas/simple-bus.yaml# Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20230924183914.51414-4-krzysztof.kozlowski@linaro.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent 09f8ee8 commit 2138c32

2 files changed

Lines changed: 88 additions & 89 deletions

File tree

arch/arm/boot/dts/qcom/qcom-ipq8064-rb3011.dts

Lines changed: 27 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,33 @@
2020
stdout-path = "serial0:115200n8";
2121
};
2222

23+
gpio-keys {
24+
compatible = "gpio-keys";
25+
pinctrl-0 = <&buttons_pins>;
26+
pinctrl-names = "default";
27+
28+
button {
29+
label = "reset";
30+
linux,code = <KEY_RESTART>;
31+
gpios = <&qcom_pinmux 66 GPIO_ACTIVE_LOW>;
32+
linux,input-type = <1>;
33+
debounce-interval = <60>;
34+
};
35+
};
36+
37+
leds {
38+
compatible = "gpio-leds";
39+
pinctrl-0 = <&leds_pins>;
40+
pinctrl-names = "default";
41+
42+
led-0 {
43+
label = "rb3011:green:user";
44+
color = <LED_COLOR_ID_GREEN>;
45+
gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
46+
default-state = "off";
47+
};
48+
};
49+
2350
memory@42000000 {
2451
reg = <0x42000000 0x3e000000>;
2552
device_type = "memory";
@@ -302,34 +329,6 @@
302329
};
303330
};
304331
};
305-
306-
gpio-keys {
307-
compatible = "gpio-keys";
308-
pinctrl-0 = <&buttons_pins>;
309-
pinctrl-names = "default";
310-
311-
button {
312-
label = "reset";
313-
linux,code = <KEY_RESTART>;
314-
gpios = <&qcom_pinmux 66 GPIO_ACTIVE_LOW>;
315-
linux,input-type = <1>;
316-
debounce-interval = <60>;
317-
};
318-
};
319-
320-
leds {
321-
compatible = "gpio-leds";
322-
pinctrl-0 = <&leds_pins>;
323-
pinctrl-names = "default";
324-
325-
led-0 {
326-
label = "rb3011:green:user";
327-
color = <LED_COLOR_ID_GREEN>;
328-
gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
329-
default-state = "off";
330-
};
331-
};
332-
333332
};
334333
};
335334

arch/arm/boot/dts/qcom/qcom-ipq8064-v1.0.dtsi

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,67 @@
1414
stdout-path = "serial0:115200n8";
1515
};
1616

17+
gpio-keys {
18+
compatible = "gpio-keys";
19+
pinctrl-0 = <&buttons_pins>;
20+
pinctrl-names = "default";
21+
22+
button-1 {
23+
label = "reset";
24+
linux,code = <KEY_RESTART>;
25+
gpios = <&qcom_pinmux 54 GPIO_ACTIVE_LOW>;
26+
linux,input-type = <1>;
27+
debounce-interval = <60>;
28+
};
29+
button-2 {
30+
label = "wps";
31+
linux,code = <KEY_WPS_BUTTON>;
32+
gpios = <&qcom_pinmux 65 GPIO_ACTIVE_LOW>;
33+
linux,input-type = <1>;
34+
debounce-interval = <60>;
35+
};
36+
};
37+
38+
leds {
39+
compatible = "gpio-leds";
40+
pinctrl-0 = <&leds_pins>;
41+
pinctrl-names = "default";
42+
43+
led-0 {
44+
label = "led_usb1";
45+
gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
46+
linux,default-trigger = "usbdev";
47+
default-state = "off";
48+
};
49+
50+
led-1 {
51+
label = "led_usb3";
52+
gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
53+
linux,default-trigger = "usbdev";
54+
default-state = "off";
55+
};
56+
57+
led-2 {
58+
label = "status_led_fail";
59+
function = LED_FUNCTION_STATUS;
60+
gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
61+
default-state = "off";
62+
};
63+
64+
led-3 {
65+
label = "sata_led";
66+
gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
67+
default-state = "off";
68+
};
69+
70+
led-4 {
71+
label = "status_led_pass";
72+
function = LED_FUNCTION_STATUS;
73+
gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;
74+
default-state = "off";
75+
};
76+
};
77+
1778
soc {
1879
gsbi@16300000 {
1980
qcom,mode = <GSBI_PROT_I2C_UART>;
@@ -64,66 +125,5 @@
64125
ports-implemented = <0x1>;
65126
status = "okay";
66127
};
67-
68-
gpio-keys {
69-
compatible = "gpio-keys";
70-
pinctrl-0 = <&buttons_pins>;
71-
pinctrl-names = "default";
72-
73-
button-1 {
74-
label = "reset";
75-
linux,code = <KEY_RESTART>;
76-
gpios = <&qcom_pinmux 54 GPIO_ACTIVE_LOW>;
77-
linux,input-type = <1>;
78-
debounce-interval = <60>;
79-
};
80-
button-2 {
81-
label = "wps";
82-
linux,code = <KEY_WPS_BUTTON>;
83-
gpios = <&qcom_pinmux 65 GPIO_ACTIVE_LOW>;
84-
linux,input-type = <1>;
85-
debounce-interval = <60>;
86-
};
87-
};
88-
89-
leds {
90-
compatible = "gpio-leds";
91-
pinctrl-0 = <&leds_pins>;
92-
pinctrl-names = "default";
93-
94-
led-0 {
95-
label = "led_usb1";
96-
gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
97-
linux,default-trigger = "usbdev";
98-
default-state = "off";
99-
};
100-
101-
led-1 {
102-
label = "led_usb3";
103-
gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
104-
linux,default-trigger = "usbdev";
105-
default-state = "off";
106-
};
107-
108-
led-2 {
109-
label = "status_led_fail";
110-
function = LED_FUNCTION_STATUS;
111-
gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
112-
default-state = "off";
113-
};
114-
115-
led-3 {
116-
label = "sata_led";
117-
gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
118-
default-state = "off";
119-
};
120-
121-
led-4 {
122-
label = "status_led_pass";
123-
function = LED_FUNCTION_STATUS;
124-
gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;
125-
default-state = "off";
126-
};
127-
};
128128
};
129129
};

0 commit comments

Comments
 (0)