Skip to content

Commit 2161ba0

Browse files
rddunlaptsbogend
authored andcommitted
MIPS: KVM: fix vz.c kernel-doc notation
Fix all kernel-doc warnings in mips/kvm/vz.c as reported by the kernel test robot: arch/mips/kvm/vz.c:471: warning: Function parameter or member 'out_compare' not described in '_kvm_vz_save_htimer' arch/mips/kvm/vz.c:471: warning: Function parameter or member 'out_cause' not described in '_kvm_vz_save_htimer' arch/mips/kvm/vz.c:471: warning: Excess function parameter 'compare' description in '_kvm_vz_save_htimer' arch/mips/kvm/vz.c:471: warning: Excess function parameter 'cause' description in '_kvm_vz_save_htimer' arch/mips/kvm/vz.c:1551: warning: No description found for return value of 'kvm_trap_vz_handle_cop_unusable' arch/mips/kvm/vz.c:1552: warning: expecting prototype for kvm_trap_vz_handle_cop_unusuable(). Prototype was for kvm_trap_vz_handle_cop_unusable() instead arch/mips/kvm/vz.c:1597: warning: No description found for return value of 'kvm_trap_vz_handle_msa_disabled' Fixes: c992a4f ("KVM: MIPS: Implement VZ support") Fixes: f4474d5 ("KVM: MIPS/VZ: Support hardware guest timer") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: linux-mips@vger.kernel.org Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> Cc: James Hogan <jhogan@kernel.org> Cc: kvm@vger.kernel.org Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent 50317b6 commit 2161ba0

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

arch/mips/kvm/vz.c

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -458,8 +458,8 @@ void kvm_vz_acquire_htimer(struct kvm_vcpu *vcpu)
458458
/**
459459
* _kvm_vz_save_htimer() - Switch to software emulation of guest timer.
460460
* @vcpu: Virtual CPU.
461-
* @compare: Pointer to write compare value to.
462-
* @cause: Pointer to write cause value to.
461+
* @out_compare: Pointer to write compare value to.
462+
* @out_cause: Pointer to write cause value to.
463463
*
464464
* Save VZ guest timer state and switch to software emulation of guest CP0
465465
* timer. The hard timer must already be in use, so preemption should be
@@ -1541,11 +1541,14 @@ static int kvm_trap_vz_handle_guest_exit(struct kvm_vcpu *vcpu)
15411541
}
15421542

15431543
/**
1544-
* kvm_trap_vz_handle_cop_unusuable() - Guest used unusable coprocessor.
1544+
* kvm_trap_vz_handle_cop_unusable() - Guest used unusable coprocessor.
15451545
* @vcpu: Virtual CPU context.
15461546
*
15471547
* Handle when the guest attempts to use a coprocessor which hasn't been allowed
15481548
* by the root context.
1549+
*
1550+
* Return: value indicating whether to resume the host or the guest
1551+
* (RESUME_HOST or RESUME_GUEST)
15491552
*/
15501553
static int kvm_trap_vz_handle_cop_unusable(struct kvm_vcpu *vcpu)
15511554
{
@@ -1592,6 +1595,9 @@ static int kvm_trap_vz_handle_cop_unusable(struct kvm_vcpu *vcpu)
15921595
*
15931596
* Handle when the guest attempts to use MSA when it is disabled in the root
15941597
* context.
1598+
*
1599+
* Return: value indicating whether to resume the host or the guest
1600+
* (RESUME_HOST or RESUME_GUEST)
15951601
*/
15961602
static int kvm_trap_vz_handle_msa_disabled(struct kvm_vcpu *vcpu)
15971603
{

0 commit comments

Comments
 (0)