media: mediatek: vpu: add missing clk_unprepare

Hans Verkuil · mchehab · commit 2192fa95276b · 2023-06-09T16:08:53.000+01:00
If vpu_clock_enable() fails, then call clk_unprepare().

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:1031 mtk_vpu_resume() warn: 'vpu-&gt;clk' from clk_prepare() not released on lines: 1020.

Signed-off-by: Hans Verkuil &lt;hverkuil-cisco@xs4all.nl&gt;
Cc: Yunfei Dong &lt;yunfei.dong@mediatek.com&gt;
Signed-off-by: Mauro Carvalho Chehab &lt;mchehab@kernel.org&gt;
diff --git a/drivers/media/platform/mediatek/vpu/mtk_vpu.c b/drivers/media/platform/mediatek/vpu/mtk_vpu.c
@@ -1018,6 +1018,7 @@ static int mtk_vpu_resume(struct device *dev)
 	clk_prepare(vpu->clk);
 	ret = vpu_clock_enable(vpu);
 	if (ret) {
+		clk_unprepare(vpu->clk);
 		dev_err(dev, "failed to enable vpu clock\n");
 		return ret;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1018,6 +1018,7 @@ static int mtk_vpu_resume(struct device *dev)`
`1018`	`1018`	`clk_prepare(vpu->clk);`
`1019`	`1019`	`ret = vpu_clock_enable(vpu);`
`1020`	`1020`	`if (ret) {`
	`1021`	`+ clk_unprepare(vpu->clk);`
`1021`	`1022`	`dev_err(dev, "failed to enable vpu clock\n");`
`1022`	`1023`	`return ret;`
`1023`	`1024`	`}`