Skip to content

Commit 21b5397

Browse files
committed
xen/blkfront: switch blkfront to use INVALID_GRANT_REF
Instead of using a private macro for an invalid grant reference use the common one. Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Signed-off-by: Juergen Gross <jgross@suse.com>
1 parent 8c9eb0e commit 21b5397

1 file changed

Lines changed: 12 additions & 14 deletions

File tree

drivers/block/xen-blkfront.c

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,6 @@ static unsigned int nr_minors;
229229
static unsigned long *minors;
230230
static DEFINE_SPINLOCK(minor_lock);
231231

232-
#define GRANT_INVALID_REF 0
233-
234232
#define PARTS_PER_DISK 16
235233
#define PARTS_PER_EXT_DISK 256
236234

@@ -321,7 +319,7 @@ static int fill_grant_buffer(struct blkfront_ring_info *rinfo, int num)
321319
gnt_list_entry->page = granted_page;
322320
}
323321

324-
gnt_list_entry->gref = GRANT_INVALID_REF;
322+
gnt_list_entry->gref = INVALID_GRANT_REF;
325323
list_add(&gnt_list_entry->node, &rinfo->grants);
326324
i++;
327325
}
@@ -350,7 +348,7 @@ static struct grant *get_free_grant(struct blkfront_ring_info *rinfo)
350348
node);
351349
list_del(&gnt_list_entry->node);
352350

353-
if (gnt_list_entry->gref != GRANT_INVALID_REF)
351+
if (gnt_list_entry->gref != INVALID_GRANT_REF)
354352
rinfo->persistent_gnts_c--;
355353

356354
return gnt_list_entry;
@@ -372,7 +370,7 @@ static struct grant *get_grant(grant_ref_t *gref_head,
372370
struct grant *gnt_list_entry = get_free_grant(rinfo);
373371
struct blkfront_info *info = rinfo->dev_info;
374372

375-
if (gnt_list_entry->gref != GRANT_INVALID_REF)
373+
if (gnt_list_entry->gref != INVALID_GRANT_REF)
376374
return gnt_list_entry;
377375

378376
/* Assign a gref to this page */
@@ -396,7 +394,7 @@ static struct grant *get_indirect_grant(grant_ref_t *gref_head,
396394
struct grant *gnt_list_entry = get_free_grant(rinfo);
397395
struct blkfront_info *info = rinfo->dev_info;
398396

399-
if (gnt_list_entry->gref != GRANT_INVALID_REF)
397+
if (gnt_list_entry->gref != INVALID_GRANT_REF)
400398
return gnt_list_entry;
401399

402400
/* Assign a gref to this page */
@@ -1221,7 +1219,7 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
12211219
list_for_each_entry_safe(persistent_gnt, n,
12221220
&rinfo->grants, node) {
12231221
list_del(&persistent_gnt->node);
1224-
if (persistent_gnt->gref != GRANT_INVALID_REF) {
1222+
if (persistent_gnt->gref != INVALID_GRANT_REF) {
12251223
gnttab_end_foreign_access(persistent_gnt->gref,
12261224
0UL);
12271225
rinfo->persistent_gnts_c--;
@@ -1283,9 +1281,9 @@ static void blkif_free_ring(struct blkfront_ring_info *rinfo)
12831281

12841282
/* Free resources associated with old device channel. */
12851283
for (i = 0; i < info->nr_ring_pages; i++) {
1286-
if (rinfo->ring_ref[i] != GRANT_INVALID_REF) {
1284+
if (rinfo->ring_ref[i] != INVALID_GRANT_REF) {
12871285
gnttab_end_foreign_access(rinfo->ring_ref[i], 0);
1288-
rinfo->ring_ref[i] = GRANT_INVALID_REF;
1286+
rinfo->ring_ref[i] = INVALID_GRANT_REF;
12891287
}
12901288
}
12911289
free_pages_exact(rinfo->ring.sring,
@@ -1475,7 +1473,7 @@ static int blkif_completion(unsigned long *id,
14751473
* to the tail of the list, so it will not be picked
14761474
* again unless we run out of persistent grants.
14771475
*/
1478-
s->grants_used[i]->gref = GRANT_INVALID_REF;
1476+
s->grants_used[i]->gref = INVALID_GRANT_REF;
14791477
list_add_tail(&s->grants_used[i]->node, &rinfo->grants);
14801478
}
14811479
}
@@ -1500,7 +1498,7 @@ static int blkif_completion(unsigned long *id,
15001498
indirect_page = s->indirect_grants[i]->page;
15011499
list_add(&indirect_page->lru, &rinfo->indirect_pages);
15021500
}
1503-
s->indirect_grants[i]->gref = GRANT_INVALID_REF;
1501+
s->indirect_grants[i]->gref = INVALID_GRANT_REF;
15041502
list_add_tail(&s->indirect_grants[i]->node, &rinfo->grants);
15051503
}
15061504
}
@@ -1687,7 +1685,7 @@ static int setup_blkring(struct xenbus_device *dev,
16871685
grant_ref_t gref[XENBUS_MAX_RING_GRANTS];
16881686

16891687
for (i = 0; i < info->nr_ring_pages; i++)
1690-
rinfo->ring_ref[i] = GRANT_INVALID_REF;
1688+
rinfo->ring_ref[i] = INVALID_GRANT_REF;
16911689

16921690
sring = alloc_pages_exact(ring_size, GFP_NOIO);
16931691
if (!sring) {
@@ -2544,13 +2542,13 @@ static void purge_persistent_grants(struct blkfront_info *info)
25442542

25452543
list_for_each_entry_safe(gnt_list_entry, tmp, &rinfo->grants,
25462544
node) {
2547-
if (gnt_list_entry->gref == GRANT_INVALID_REF ||
2545+
if (gnt_list_entry->gref == INVALID_GRANT_REF ||
25482546
!gnttab_try_end_foreign_access(gnt_list_entry->gref))
25492547
continue;
25502548

25512549
list_del(&gnt_list_entry->node);
25522550
rinfo->persistent_gnts_c--;
2553-
gnt_list_entry->gref = GRANT_INVALID_REF;
2551+
gnt_list_entry->gref = INVALID_GRANT_REF;
25542552
list_add_tail(&gnt_list_entry->node, &grants);
25552553
}
25562554

0 commit comments

Comments
 (0)