Skip to content

Commit 21bd5fb

Browse files
robherringkrzk
authored andcommitted
arm64: dts: apm/shadowcat: More clock clean-ups
A fixed-factor-clock only provides 1 clock, so "#clock-cells" must be 0. The "snps,designware-i2c" node is not a clock provider, so drop "#clock-cells. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Link: https://patch.msgid.link/20251216-dt-apm-v1-1-0bf2bf8b982c@kernel.org Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
1 parent 7dd84bb commit 21bd5fb

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

arch/arm64/boot/dts/apm/apm-shadowcat.dtsi

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@
295295

296296
socplldiv2: socplldiv2 {
297297
compatible = "fixed-factor-clock";
298-
#clock-cells = <1>;
298+
#clock-cells = <0>;
299299
clocks = <&socpll 0>;
300300
clock-mult = <1>;
301301
clock-div = <2>;
@@ -305,7 +305,7 @@
305305
ahbclk: ahbclk@17000000 {
306306
compatible = "apm,xgene-device-clock";
307307
#clock-cells = <1>;
308-
clocks = <&socplldiv2 0>;
308+
clocks = <&socplldiv2>;
309309
reg = <0x0 0x17000000 0x0 0x2000>;
310310
reg-names = "div-reg";
311311
divider-offset = <0x164>;
@@ -329,7 +329,7 @@
329329
sdioclk: sdioclk@1f2ac000 {
330330
compatible = "apm,xgene-device-clock";
331331
#clock-cells = <1>;
332-
clocks = <&socplldiv2 0>;
332+
clocks = <&socplldiv2>;
333333
reg = <0x0 0x1f2ac000 0x0 0x1000
334334
0x0 0x17000000 0x0 0x2000>;
335335
reg-names = "csr-reg", "div-reg";
@@ -346,7 +346,7 @@
346346
pcie0clk: pcie0clk@1f2bc000 {
347347
compatible = "apm,xgene-device-clock";
348348
#clock-cells = <1>;
349-
clocks = <&socplldiv2 0>;
349+
clocks = <&socplldiv2>;
350350
reg = <0x0 0x1f2bc000 0x0 0x1000>;
351351
reg-names = "csr-reg";
352352
clock-output-names = "pcie0clk";
@@ -355,7 +355,7 @@
355355
pcie1clk: pcie1clk@1f2cc000 {
356356
compatible = "apm,xgene-device-clock";
357357
#clock-cells = <1>;
358-
clocks = <&socplldiv2 0>;
358+
clocks = <&socplldiv2>;
359359
reg = <0x0 0x1f2cc000 0x0 0x1000>;
360360
reg-names = "csr-reg";
361361
clock-output-names = "pcie1clk";
@@ -364,7 +364,7 @@
364364
xge0clk: xge0clk@1f61c000 {
365365
compatible = "apm,xgene-device-clock";
366366
#clock-cells = <1>;
367-
clocks = <&socplldiv2 0>;
367+
clocks = <&socplldiv2>;
368368
reg = <0x0 0x1f61c000 0x0 0x1000>;
369369
reg-names = "csr-reg";
370370
enable-mask = <0x3>;
@@ -375,7 +375,7 @@
375375
xge1clk: xge1clk@1f62c000 {
376376
compatible = "apm,xgene-device-clock";
377377
#clock-cells = <1>;
378-
clocks = <&socplldiv2 0>;
378+
clocks = <&socplldiv2>;
379379
reg = <0x0 0x1f62c000 0x0 0x1000>;
380380
reg-names = "csr-reg";
381381
enable-mask = <0x3>;
@@ -386,7 +386,7 @@
386386
rngpkaclk: rngpkaclk@17000000 {
387387
compatible = "apm,xgene-device-clock";
388388
#clock-cells = <1>;
389-
clocks = <&socplldiv2 0>;
389+
clocks = <&socplldiv2>;
390390
reg = <0x0 0x17000000 0x0 0x2000>;
391391
reg-names = "csr-reg";
392392
csr-offset = <0xc>;
@@ -799,7 +799,6 @@
799799
compatible = "snps,designware-i2c";
800800
reg = <0x0 0x10511000 0x0 0x1000>;
801801
interrupts = <0 0x45 0x4>;
802-
#clock-cells = <1>;
803802
clocks = <&sbapbclk 0>;
804803
};
805804

0 commit comments

Comments
 (0)