Skip to content

Commit 22a9402

Browse files
srebroonie
authored andcommitted
regulator: rk808: revert to synchronous probing
The rk808 driver registers a bunch of regulator devices in a loop. If one of the later regulators fails to register (usually because its input supply is not yet available) everything will be unrolled (i.e. previously registered regulators will be unregistered). With asynchronous registration there might already be consumers, though. We do not have the necessary infrastructure to properly unregister the consumer device, so this scenario should be avoided. First checking all input supplies or disallowing usage of the regulators until all are registered does not work, since there can be self-references (e.g. DCDC channels providing the supply of LDOs). The only sensible solution I found is registering the regulator devices asynchronously, so that we do not have to unroll. Since this is a major rework let's revert back to synchronous probing for now to fix the issue at hand. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Link: https://lore.kernel.org/r/20230504173618.142075-14-sebastian.reichel@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5111c93 commit 22a9402

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/regulator/rk808-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1355,7 +1355,7 @@ static struct platform_driver rk808_regulator_driver = {
13551355
.probe = rk808_regulator_probe,
13561356
.driver = {
13571357
.name = "rk808-regulator",
1358-
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
1358+
.probe_type = PROBE_FORCE_SYNCHRONOUS,
13591359
},
13601360
};
13611361

0 commit comments

Comments
 (0)