Skip to content

Commit 22dc378

Browse files
Tom Rixlag-linaro
authored andcommitted
leds: flash: Set variables mvflash_{3,4}ch_regs storage-class-specifier to static
Smatch reports: drivers/leds/flash/leds-qcom-flash.c:103:18: warning: symbol 'mvflash_3ch_regs' was not declared. Should it be static? drivers/leds/flash/leds-qcom-flash.c:115:18: warning: symbol 'mvflash_4ch_regs' was not declared. Should it be static? These variables are only used locally, so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230317191341.1670660-1-trix@redhat.com
1 parent 560f2eb commit 22dc378

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/leds/flash/leds-qcom-flash.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ enum {
100100
REG_MAX_COUNT,
101101
};
102102

103-
struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
103+
static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
104104
REG_FIELD(0x08, 0, 7), /* status1 */
105105
REG_FIELD(0x09, 0, 7), /* status2 */
106106
REG_FIELD(0x0a, 0, 7), /* status3 */
@@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
112112
REG_FIELD(0x4c, 0, 2), /* chan_en */
113113
};
114114

115-
struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
115+
static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
116116
REG_FIELD(0x06, 0, 7), /* status1 */
117117
REG_FIELD(0x07, 0, 6), /* status2 */
118118
REG_FIELD(0x09, 0, 7), /* status3 */

0 commit comments

Comments
 (0)