Skip to content

Commit 22eb787

Browse files
anakryikoAlexei Starovoitov
authored andcommitted
tools/bpftool: Fix skeleton codegen
Remove unnecessary check at the end of codegen() routine which makes codegen() to always fail and exit bpftool with error code. Positive value of variable n is not an indicator of a failure. Fixes: 2c4779e ("tools, bpftool: Exit on error in function codegen") Signed-off-by: Andrii Nakryiko <andriin@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Reviewed-by: Tobias Klauser <tklauser@distanz.ch> Link: https://lore.kernel.org/bpf/20200612201603.680852-1-andriin@fb.com
1 parent 60e5ca8 commit 22eb787

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

tools/bpf/bpftool/gen.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,6 @@ static void codegen(const char *template, ...)
257257
va_end(args);
258258

259259
free(s);
260-
if (n)
261-
exit(-1);
262260
}
263261

264262
static int do_skeleton(int argc, char **argv)

0 commit comments

Comments
 (0)