Skip to content

Commit 22f3571

Browse files
mszyprowbjorn-helgaas
authored andcommitted
PCI: exynos: Correct generic PHY usage
The proper initialization for generic PHYs is to call first phy_init(), then phy_power_on(). While touching this, remove the phy_reset() call. It is just a left-over from the obsoleted Exynos5440 support and the current exynos-pcie PHY driver doesn't even support this function. It is also rarely used by other drivers. Link: https://lore.kernel.org/r/20220628220409.26545-2-m.szyprowski@samsung.com Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Chanho Park <chanho61.park@samsung.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent f281222 commit 22f3571

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/pci/controller/dwc/pci-exynos.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct dw_pcie_rp *pp)
258258

259259
exynos_pcie_assert_core_reset(ep);
260260

261-
phy_reset(ep->phy);
262-
phy_power_on(ep->phy);
263261
phy_init(ep->phy);
262+
phy_power_on(ep->phy);
264263

265264
exynos_pcie_deassert_core_reset(ep);
266265
exynos_pcie_enable_irq_pulse(ep);

0 commit comments

Comments
 (0)