Skip to content

Commit 233d331

Browse files
rddunlapjernejsk
authored andcommitted
clk: sunxi: a20-gmac: fix kernel-doc warnings
Move the function kernel-doc comment to be immediately before the function implementation, then add a function parameter description to prevent kernel-doc warnings: clk-a20-gmac.c:43: warning: expecting prototype for sun7i_a20_gmac_clk_setup(). Prototype was for SUN7I_A20_GMAC_GPIT() instead clk-a20-gmac.c:53: warning: Function parameter or struct member 'node' not described in 'sun7i_a20_gmac_clk_setup' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Emilio López <emilio@elopez.com.ar> Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: <linux-clk@vger.kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Samuel Holland <samuel@sholland.org> Cc: <linux-arm-kernel@lists.infradead.org> Cc: <linux-sunxi@lists.linux.dev> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Link: https://lore.kernel.org/r/20240121051837.17564-1-rdunlap@infradead.org Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
1 parent 6613476 commit 233d331

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

drivers/clk/sunxi/clk-a20-gmac.c

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,19 @@
1515

1616
static DEFINE_SPINLOCK(gmac_lock);
1717

18+
19+
#define SUN7I_A20_GMAC_GPIT 2
20+
#define SUN7I_A20_GMAC_MASK 0x3
21+
#define SUN7I_A20_GMAC_PARENTS 2
22+
23+
static u32 sun7i_a20_gmac_mux_table[SUN7I_A20_GMAC_PARENTS] = {
24+
0x00, /* Select mii_phy_tx_clk */
25+
0x02, /* Select gmac_int_tx_clk */
26+
};
27+
1828
/**
1929
* sun7i_a20_gmac_clk_setup - Setup function for A20/A31 GMAC clock module
30+
* @node: &struct device_node for the clock
2031
*
2132
* This clock looks something like this
2233
* ________________________
@@ -39,16 +50,6 @@ static DEFINE_SPINLOCK(gmac_lock);
3950
* enable/disable this clock to configure the required state. The clock
4051
* driver then responds by auto-reparenting the clock.
4152
*/
42-
43-
#define SUN7I_A20_GMAC_GPIT 2
44-
#define SUN7I_A20_GMAC_MASK 0x3
45-
#define SUN7I_A20_GMAC_PARENTS 2
46-
47-
static u32 sun7i_a20_gmac_mux_table[SUN7I_A20_GMAC_PARENTS] = {
48-
0x00, /* Select mii_phy_tx_clk */
49-
0x02, /* Select gmac_int_tx_clk */
50-
};
51-
5253
static void __init sun7i_a20_gmac_clk_setup(struct device_node *node)
5354
{
5455
struct clk *clk;

0 commit comments

Comments
 (0)