Skip to content

Commit 23a1a57

Browse files
neilbrownchucklever
authored andcommitted
NFS: switch the callback service back to non-pooled.
Now that thread management is consistent there is no need for nfs-callback to use svc_create_pooled() as introduced in Commit df807ff ("NFSv4.x/callback: Create the callback service through svc_create_pooled"). So switch back to svc_create(). If service pools were configured, but the number of threads were left at '1', nfs callback may not work reliably when svc_create_pooled() is used. Signed-off-by: NeilBrown <neilb@suse.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 6b044fb commit 23a1a57

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/nfs/callback.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
286286
printk(KERN_WARNING "nfs_callback_create_svc: no kthread, %d users??\n",
287287
cb_info->users);
288288

289-
serv = svc_create_pooled(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
289+
serv = svc_create(&nfs4_callback_program, NFS4_CALLBACK_BUFSIZE, sv_ops);
290290
if (!serv) {
291291
printk(KERN_ERR "nfs_callback_create_svc: create service failed\n");
292292
return ERR_PTR(-ENOMEM);

0 commit comments

Comments
 (0)