drm/i915/selftest: Fix an error code in live_noa_gpr()

Dan Carpenter · ickle · commit 23ec9f42241a · 2020-07-14T18:16:15.000+01:00
The error code needs to be set on this path. It currently returns success. Fixes: ed2690a ("drm/i915/selftest: Check that GPR are restored across noa_wait") Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20200714143652.GA337376@mwanda
diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c
@@ -357,6 +357,7 @@ static int live_noa_gpr(void *arg)
 
 		cs = intel_ring_begin(rq, 4);
 		if (IS_ERR(cs)) {
+			err = PTR_ERR(cs);
 			i915_request_add(rq);
 			goto out_rq;
 		}

Original file line number	Diff line number	Diff line change
`@@ -357,6 +357,7 @@ static int live_noa_gpr(void *arg)`
`357`	`357`
`358`	`358`	`cs = intel_ring_begin(rq, 4);`
`359`	`359`	`if (IS_ERR(cs)) {`
	`360`	`+ err = PTR_ERR(cs);`
`360`	`361`	`i915_request_add(rq);`
`361`	`362`	`goto out_rq;`
`362`	`363`	`}`