Skip to content

Commit 242e10a

Browse files
Baolin Wangtorvalds
authored andcommitted
mm/damon: remove redundant page validation
It will never get a NULL page by pte_page() as discussed in thread [1], thus remove the redundant page validation to fix below Smatch static checker warning. mm/damon/vaddr.c:405 damon_hugetlb_mkold() warn: 'page' can't be NULL. [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/ Link: https://lkml.kernel.org/r/6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: SeongJae Park <sj@kernel.org> Acked-by: David Rientjes <rientjes@google.com> Acked-by: Souptick Joarder <jrdr.linux@gmail.com> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 1971bd6 commit 242e10a

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

mm/damon/vaddr.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -402,9 +402,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm,
402402
pte_t entry = huge_ptep_get(pte);
403403
struct page *page = pte_page(entry);
404404

405-
if (!page)
406-
return;
407-
408405
get_page(page);
409406

410407
if (pte_young(entry)) {
@@ -564,9 +561,6 @@ static int damon_young_hugetlb_entry(pte_t *pte, unsigned long hmask,
564561
goto out;
565562

566563
page = pte_page(entry);
567-
if (!page)
568-
goto out;
569-
570564
get_page(page);
571565

572566
if (pte_young(entry) || !page_is_idle(page) ||

0 commit comments

Comments
 (0)