Skip to content

Commit 247c8d2

Browse files
arndbbrauner
authored andcommitted
fs: pipe: reveal missing function protoypes
A couple of functions from fs/pipe.c are used both internally and for the watch queue code, but the declaration is only visible when the latter is enabled: fs/pipe.c:1254:5: error: no previous prototype for 'pipe_resize_ring' fs/pipe.c:758:15: error: no previous prototype for 'account_pipe_buffers' fs/pipe.c:764:6: error: no previous prototype for 'too_many_pipe_buffers_soft' fs/pipe.c:771:6: error: no previous prototype for 'too_many_pipe_buffers_hard' fs/pipe.c:777:6: error: no previous prototype for 'pipe_is_unprivileged_user' Make the visible unconditionally to avoid these warnings. Fixes: c73be61 ("pipe: Add general notification queue support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Message-Id: <20230516195629.551602-1-arnd@kernel.org> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent df67cb4 commit 247c8d2

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

include/linux/pipe_fs_i.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,18 +261,14 @@ void generic_pipe_buf_release(struct pipe_inode_info *, struct pipe_buffer *);
261261

262262
extern const struct pipe_buf_operations nosteal_pipe_buf_ops;
263263

264-
#ifdef CONFIG_WATCH_QUEUE
265264
unsigned long account_pipe_buffers(struct user_struct *user,
266265
unsigned long old, unsigned long new);
267266
bool too_many_pipe_buffers_soft(unsigned long user_bufs);
268267
bool too_many_pipe_buffers_hard(unsigned long user_bufs);
269268
bool pipe_is_unprivileged_user(void);
270-
#endif
271269

272270
/* for F_SETPIPE_SZ and F_GETPIPE_SZ */
273-
#ifdef CONFIG_WATCH_QUEUE
274271
int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots);
275-
#endif
276272
long pipe_fcntl(struct file *, unsigned int, unsigned long arg);
277273
struct pipe_inode_info *get_pipe_info(struct file *file, bool for_splice);
278274

0 commit comments

Comments
 (0)