Skip to content

Commit 24a4258

Browse files
floatiouskwilczynski
authored andcommitted
selftests: pci_endpoint: Use IRQ_TYPE_* defines from UAPI header
In order to improve readability, use the IRQ_TYPE_* defines from the UAPI header rather than using raw values. No functional change. Signed-off-by: Niklas Cassel <cassel@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Link: https://lore.kernel.org/r/20250310111016.859445-12-cassel@kernel.org
1 parent 64a7704 commit 24a4258

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

tools/testing/selftests/pci_endpoint/pci_endpoint_test.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ TEST_F(pci_ep_basic, LEGACY_IRQ_TEST)
9999
{
100100
int ret;
101101

102-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 0);
102+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_INTX);
103103
ASSERT_EQ(0, ret) TH_LOG("Can't set Legacy IRQ type");
104104

105105
pci_ep_ioctl(PCITEST_GET_IRQTYPE, 0);
106-
ASSERT_EQ(0, ret) TH_LOG("Can't get Legacy IRQ type");
106+
ASSERT_EQ(PCITEST_IRQ_TYPE_INTX, ret) TH_LOG("Can't get Legacy IRQ type");
107107

108108
pci_ep_ioctl(PCITEST_LEGACY_IRQ, 0);
109109
EXPECT_FALSE(ret) TH_LOG("Test failed for Legacy IRQ");
@@ -113,11 +113,11 @@ TEST_F(pci_ep_basic, MSI_TEST)
113113
{
114114
int ret, i;
115115

116-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 1);
116+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
117117
ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
118118

119119
pci_ep_ioctl(PCITEST_GET_IRQTYPE, 0);
120-
ASSERT_EQ(1, ret) TH_LOG("Can't get MSI IRQ type");
120+
ASSERT_EQ(PCITEST_IRQ_TYPE_MSI, ret) TH_LOG("Can't get MSI IRQ type");
121121

122122
for (i = 1; i <= 32; i++) {
123123
pci_ep_ioctl(PCITEST_MSI, i);
@@ -129,11 +129,11 @@ TEST_F(pci_ep_basic, MSIX_TEST)
129129
{
130130
int ret, i;
131131

132-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 2);
132+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSIX);
133133
ASSERT_EQ(0, ret) TH_LOG("Can't set MSI-X IRQ type");
134134

135135
pci_ep_ioctl(PCITEST_GET_IRQTYPE, 0);
136-
ASSERT_EQ(2, ret) TH_LOG("Can't get MSI-X IRQ type");
136+
ASSERT_EQ(PCITEST_IRQ_TYPE_MSIX, ret) TH_LOG("Can't get MSI-X IRQ type");
137137

138138
for (i = 1; i <= 2048; i++) {
139139
pci_ep_ioctl(PCITEST_MSIX, i);
@@ -181,7 +181,7 @@ TEST_F(pci_ep_data_transfer, READ_TEST)
181181
if (variant->use_dma)
182182
param.flags = PCITEST_FLAGS_USE_DMA;
183183

184-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 1);
184+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
185185
ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
186186

187187
for (i = 0; i < ARRAY_SIZE(test_size); i++) {
@@ -200,7 +200,7 @@ TEST_F(pci_ep_data_transfer, WRITE_TEST)
200200
if (variant->use_dma)
201201
param.flags = PCITEST_FLAGS_USE_DMA;
202202

203-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 1);
203+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
204204
ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
205205

206206
for (i = 0; i < ARRAY_SIZE(test_size); i++) {
@@ -219,7 +219,7 @@ TEST_F(pci_ep_data_transfer, COPY_TEST)
219219
if (variant->use_dma)
220220
param.flags = PCITEST_FLAGS_USE_DMA;
221221

222-
pci_ep_ioctl(PCITEST_SET_IRQTYPE, 1);
222+
pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_MSI);
223223
ASSERT_EQ(0, ret) TH_LOG("Can't set MSI IRQ type");
224224

225225
for (i = 0; i < ARRAY_SIZE(test_size); i++) {

0 commit comments

Comments
 (0)