ASoC: codecs: Fix error handling in aw_dev_get_dsp_status function

Zhu Jun · broonie · commit 251ce34a446e · 2024-10-10T12:15:01.000+01:00
Added proper error handling for register value check that return -EPERM when register value does not meet expected condition Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> Link: https://patch.msgid.link/20241009073938.7472-1-zhujun2@cmss.chinamobile.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/aw88399.c b/sound/soc/codecs/aw88399.c
@@ -656,7 +656,7 @@ static int aw_dev_get_dsp_status(struct aw_device *aw_dev)
 	if (ret)
 		return ret;
 	if (!(reg_val & (~AW88399_WDT_CNT_MASK)))
-		ret = -EPERM;
+		return -EPERM;
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -656,7 +656,7 @@ static int aw_dev_get_dsp_status(struct aw_device *aw_dev)`
`656`	`656`	`if (ret)`
`657`	`657`	`return ret;`
`658`	`658`	`if (!(reg_val & (~AW88399_WDT_CNT_MASK)))`
`659`		`- ret = -EPERM;`
	`659`	`+ return -EPERM;`
`660`	`660`
`661`	`661`	`return 0;`
`662`	`662`	`}`