Skip to content

Commit 254f333

Browse files
Hans Verkuilmchehab
authored andcommitted
media: rockchip: rga: fix clock cleanup
Fix this smatch warning: drivers/media/platform/rockchip/rga/rga.c:734 rga_enable_clocks() warn: 'rga->sclk' from clk_prepare_enable() not released on lines: 734. The reason is that aclk should be disabled/unprepared before sclk, instead of the other way around. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Jacob Chen <jacob-chen@iotwrt.com> Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Reviewed-by: Michael Tretter <m.tretter@pengutronix.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent f7c4873 commit 254f333

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • drivers/media/platform/rockchip/rga

drivers/media/platform/rockchip/rga/rga.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,10 +723,10 @@ static int rga_enable_clocks(struct rockchip_rga *rga)
723723

724724
return 0;
725725

726-
err_disable_sclk:
727-
clk_disable_unprepare(rga->sclk);
728726
err_disable_aclk:
729727
clk_disable_unprepare(rga->aclk);
728+
err_disable_sclk:
729+
clk_disable_unprepare(rga->sclk);
730730

731731
return ret;
732732
}

0 commit comments

Comments
 (0)