Skip to content

Commit 256748d

Browse files
DiogoSilva14kuba-moo
authored andcommitted
net: phy: ti: add PHY_RST_AFTER_CLK_EN flag
DP83848 datasheet (section 4.7.2) indicates that the reset pin should be toggled after the clocks are running. Add the PHY_RST_AFTER_CLK_EN to make sure that this indication is respected. In my experience not having this flag enabled would lead to, on some boots, the wrong MII mode being selected if the PHY was initialized on the bootloader and was receiving data during Linux boot. Signed-off-by: Diogo Silva <diogompaissilva@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Fixes: 34e45ad ("net: phy: dp83848: Add TI DP83848 Ethernet PHY") Link: https://patch.msgid.link/20241102151504.811306-1-paissilva@ld-100007.ds1.internal Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9eaff63 commit 256748d

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/net/phy/dp83848.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
147147
/* IRQ related */ \
148148
.config_intr = dp83848_config_intr, \
149149
.handle_interrupt = dp83848_handle_interrupt, \
150+
\
151+
.flags = PHY_RST_AFTER_CLK_EN, \
150152
}
151153

152154
static struct phy_driver dp83848_driver[] = {

0 commit comments

Comments
 (0)