Skip to content

Commit 25e7976

Browse files
committed
drm/i915/mtl: do not enable render power-gating on MTL
Multiple CI tests fails with forcewake ack timeouts if render power gating is enabled. BSpec 52698 states it should be 0 for MTL, but apparently this info is outdated. Anyway since the patch makes MTL pass basic tests added FIXME tag informing this is temporary workaround. v2: added FIXME tag Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4983 Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230517-mtl_disable_render_pg-v2-1-0b51180a43f0@intel.com
1 parent 6f22587 commit 25e7976

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

drivers/gpu/drm/i915/gt/intel_rc6.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,14 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
117117
GEN6_RC_CTL_RC6_ENABLE |
118118
GEN6_RC_CTL_EI_MODE(1);
119119

120-
/* Wa_16011777198 - Render powergating must remain disabled */
121-
if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
120+
/*
121+
* Wa_16011777198 and BSpec 52698 - Render powergating must be off.
122+
* FIXME BSpec is outdated, disabling powergating for MTL is just
123+
* temporary wa and should be removed after fixing real cause
124+
* of forcewake timeouts.
125+
*/
126+
if (IS_METEORLAKE(gt->i915) ||
127+
IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
122128
IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
123129
pg_enable =
124130
GEN9_MEDIA_PG_ENABLE |

0 commit comments

Comments
 (0)