Skip to content

Commit 2604f31

Browse files
pinchartlffainelli
authored andcommitted
dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Add gpio child node
Unlike the other child nodes of the raspberrypi,bcm2835-firmware device, the gpio child is documented in a legacy text-based binding in gpio/raspberrypi,firmware-gpio.txt. This causes DT validation failures: arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb: 'gpio' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml# Convert the binding to YAML and move it to raspberrypi,bcm2835-firmware.yaml. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Stefan Wahren <wahrenst@gmx.net> Tested-by: Ivan T. Ivanov <iivanov@suse.de> Link: https://lore.kernel.org/r/20240326195807.15163-2-laurent.pinchart@ideasonboard.com Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
1 parent 4cece76 commit 2604f31

2 files changed

Lines changed: 30 additions & 30 deletions

File tree

Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,30 @@ properties:
4646
- compatible
4747
- "#clock-cells"
4848

49+
gpio:
50+
type: object
51+
additionalProperties: false
52+
53+
properties:
54+
compatible:
55+
const: raspberrypi,firmware-gpio
56+
57+
gpio-controller: true
58+
59+
"#gpio-cells":
60+
const: 2
61+
description:
62+
The first cell is the pin number, and the second cell is used to
63+
specify the gpio polarity (GPIO_ACTIVE_HIGH or GPIO_ACTIVE_LOW).
64+
65+
gpio-line-names:
66+
minItems: 8
67+
68+
required:
69+
- compatible
70+
- gpio-controller
71+
- "#gpio-cells"
72+
4973
reset:
5074
type: object
5175
additionalProperties: false
@@ -96,6 +120,12 @@ examples:
96120
#clock-cells = <1>;
97121
};
98122
123+
expgpio: gpio {
124+
compatible = "raspberrypi,firmware-gpio";
125+
gpio-controller;
126+
#gpio-cells = <2>;
127+
};
128+
99129
reset: reset {
100130
compatible = "raspberrypi,firmware-reset";
101131
#reset-cells = <1>;

Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)