Skip to content

Commit 260aecd

Browse files
Wan Jiabingjoergroedel
authored andcommitted
iommu/dart: Use kmemdup instead of kzalloc and memcpy
Fix following coccicheck warning: drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Acked-by: Sven Peter <sven@svenpeter.dev> Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Link: https://lore.kernel.org/r/20211013063441.29888-1-wanjiabing@vivo.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 9e1ff30 commit 260aecd

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/iommu/apple-dart.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -702,13 +702,12 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
702702
if (!group)
703703
goto out;
704704

705-
group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
705+
group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);
706706
if (!group_master_cfg) {
707707
iommu_group_put(group);
708708
goto out;
709709
}
710710

711-
memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
712711
iommu_group_set_iommudata(group, group_master_cfg,
713712
apple_dart_release_group);
714713

0 commit comments

Comments
 (0)