Skip to content

Commit 26623ee

Browse files
Zheng Yongjundtor
authored andcommitted
Input: stmfts - fix reference leak in stmfts_input_open
pm_runtime_get_sync() will increment pm usage counter even it failed. Forgetting to call pm_runtime_put_noidle will result in reference leak in stmfts_input_open, so we should fix it. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 409353c commit 26623ee

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

drivers/input/touchscreen/stmfts.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,11 @@ static int stmfts_input_open(struct input_dev *dev)
339339

340340
err = pm_runtime_get_sync(&sdata->client->dev);
341341
if (err < 0)
342-
return err;
342+
goto out;
343343

344344
err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON);
345345
if (err)
346-
return err;
346+
goto out;
347347

348348
mutex_lock(&sdata->mutex);
349349
sdata->running = true;
@@ -366,7 +366,9 @@ static int stmfts_input_open(struct input_dev *dev)
366366
"failed to enable touchkey\n");
367367
}
368368

369-
return 0;
369+
out:
370+
pm_runtime_put_noidle(&sdata->client->dev);
371+
return err;
370372
}
371373

372374
static void stmfts_input_close(struct input_dev *dev)

0 commit comments

Comments
 (0)