Skip to content

Commit 26803ba

Browse files
committed
Merge tag 'gpio-fixes-for-v5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux
Pull gpio fixes from Bartosz Golaszewski: - grammar and formatting fixes in comments for gpio-ts4900 - correct links in gpio-ts5500 - fix a warning in doc generation for the core GPIO documentation * tag 'gpio-fixes-for-v5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux: gpio: ts5500: Fix Links to Technologic Systems web resources gpio: Properly document parent data union gpio: ts4900: Fix comment formatting and grammar
2 parents aa240ee + 24f71ae commit 26803ba

3 files changed

Lines changed: 17 additions & 12 deletions

File tree

drivers/gpio/gpio-ts4900.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
4747
{
4848
struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
4949

50-
/* Only clear the OE bit here, requires a RMW. Prevents potential issue
51-
* with OE and data getting to the physical pin at different times.
50+
/*
51+
* Only clear the OE bit here, requires a RMW. Prevents a potential issue
52+
* with OE and DAT getting to the physical pin at different times.
5253
*/
5354
return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
5455
}
@@ -60,9 +61,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
6061
unsigned int reg;
6162
int ret;
6263

63-
/* If changing from an input to an output, we need to first set the
64-
* proper data bit to what is requested and then set OE bit. This
65-
* prevents a glitch that can occur on the IO line
64+
/*
65+
* If changing from an input to an output, we need to first set the
66+
* GPIO's DAT bit to what is requested and then set the OE bit. This
67+
* prevents a glitch that can occur on the IO line.
6668
*/
6769
regmap_read(priv->regmap, offset, &reg);
6870
if (!(reg & TS4900_GPIO_OE)) {

drivers/gpio/gpio-ts5500.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
* Actually, the following platforms have DIO support:
1212
*
1313
* TS-5500:
14-
* Documentation: http://wiki.embeddedarm.com/wiki/TS-5500
14+
* Documentation: https://docs.embeddedts.com/TS-5500
1515
* Blocks: DIO1, DIO2 and LCD port.
1616
*
1717
* TS-5600:
18-
* Documentation: http://wiki.embeddedarm.com/wiki/TS-5600
18+
* Documentation: https://docs.embeddedts.com/TS-5600
1919
* Blocks: LCD port (identical to TS-5500 LCD).
2020
*/
2121

include/linux/gpio/driver.h

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,16 @@ struct gpio_irq_chip {
168168

169169
/**
170170
* @parent_handler_data:
171+
*
172+
* If @per_parent_data is false, @parent_handler_data is a single
173+
* pointer used as the data associated with every parent interrupt.
174+
*
171175
* @parent_handler_data_array:
172176
*
173-
* Data associated, and passed to, the handler for the parent
174-
* interrupt. Can either be a single pointer if @per_parent_data
175-
* is false, or an array of @num_parents pointers otherwise. If
176-
* @per_parent_data is true, @parent_handler_data_array cannot be
177-
* NULL.
177+
* If @per_parent_data is true, @parent_handler_data_array is
178+
* an array of @num_parents pointers, and is used to associate
179+
* different data for each parent. This cannot be NULL if
180+
* @per_parent_data is true.
178181
*/
179182
union {
180183
void *parent_handler_data;

0 commit comments

Comments
 (0)