Skip to content

Commit 26a8b09

Browse files
jhovoldjwrdegoede
authored andcommitted
platform/x86: intel_pmc_core: fix memleak on registration failure
In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name). Fixes: 938835a ("platform/x86: intel_pmc_core: do not create a static struct device") Cc: stable@vger.kernel.org # 5.9 Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20211222105023.6205-1-johan@kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 4f6c131 commit 26a8b09

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/x86/intel/pmc/pltdrv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void)
6565

6666
retval = platform_device_register(pmc_core_device);
6767
if (retval)
68-
kfree(pmc_core_device);
68+
platform_device_put(pmc_core_device);
6969

7070
return retval;
7171
}

0 commit comments

Comments
 (0)