Skip to content

Commit 26ace87

Browse files
vsyrjalatursulin
authored andcommitted
drm/i915/fbc: Fix the plane end Y offset check
We lost the required >>16 when I refactored the FBC plane state checks. Bring it back so the check does what it's supposed to. Cc: Mika Kahola <mika.kahola@intel.com> Fixes: 2e6c99f ("drm/i915/fbc: Nuke lots of crap from intel_fbc_state_cache") Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220210103107.24492-1-ville.syrjala@linux.intel.com Reviewed-by: Mika Kahola <mika.kahola@intel.com> (cherry picked from commit f7bc440) Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
1 parent ea95842 commit 26ace87

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/gpu/drm/i915/display/intel_fbc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
11151115

11161116
/* Wa_22010751166: icl, ehl, tgl, dg1, rkl */
11171117
if (DISPLAY_VER(i915) >= 11 &&
1118-
(plane_state->view.color_plane[0].y + drm_rect_height(&plane_state->uapi.src)) & 3) {
1118+
(plane_state->view.color_plane[0].y +
1119+
(drm_rect_height(&plane_state->uapi.src) >> 16)) & 3) {
11191120
plane_state->no_fbc_reason = "plane end Y offset misaligned";
11201121
return false;
11211122
}

0 commit comments

Comments
 (0)