Skip to content

Commit 26c35d1

Browse files
Jason-JH.LinChun-Kuang Hu
authored andcommitted
drm/mediatek: Add crtc path enum for all_drm_priv array
Add mtk_drm_crtc_path enum for each display path. Instead of using array index of all_drm_priv in mtk_drm_kms_init(), mtk_drm_crtc_path enum can make code more readable. Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> Reviewed-by: Fei Shao <fshao@chromium.org> Reviewed-by: CK Hu <ck.hu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Tested-by: Fei Shao <fshao@chromium.org> Link: https://patchwork.kernel.org/project/dri-devel/patch/20231004024013.18956-3-jason-jh.lin@mediatek.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent ff64e4c commit 26c35d1

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

drivers/gpu/drm/mediatek/mtk_drm_drv.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -469,21 +469,21 @@ static int mtk_drm_kms_init(struct drm_device *drm)
469469
for (j = 0; j < private->data->mmsys_dev_num; j++) {
470470
priv_n = private->all_drm_private[j];
471471

472-
if (i == 0 && priv_n->data->main_len) {
472+
if (i == CRTC_MAIN && priv_n->data->main_len) {
473473
ret = mtk_drm_crtc_create(drm, priv_n->data->main_path,
474474
priv_n->data->main_len, j);
475475
if (ret)
476476
goto err_component_unbind;
477477

478478
continue;
479-
} else if (i == 1 && priv_n->data->ext_len) {
479+
} else if (i == CRTC_EXT && priv_n->data->ext_len) {
480480
ret = mtk_drm_crtc_create(drm, priv_n->data->ext_path,
481481
priv_n->data->ext_len, j);
482482
if (ret)
483483
goto err_component_unbind;
484484

485485
continue;
486-
} else if (i == 2 && priv_n->data->third_len) {
486+
} else if (i == CRTC_THIRD && priv_n->data->third_len) {
487487
ret = mtk_drm_crtc_create(drm, priv_n->data->third_path,
488488
priv_n->data->third_len, j);
489489
if (ret)

drivers/gpu/drm/mediatek/mtk_drm_drv.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,17 @@
99
#include <linux/io.h>
1010
#include "mtk_drm_ddp_comp.h"
1111

12-
#define MAX_CRTC 3
1312
#define MAX_CONNECTOR 2
1413
#define DDP_COMPONENT_DRM_OVL_ADAPTOR (DDP_COMPONENT_ID_MAX + 1)
1514
#define DDP_COMPONENT_DRM_ID_MAX (DDP_COMPONENT_DRM_OVL_ADAPTOR + 1)
1615

16+
enum mtk_drm_crtc_path {
17+
CRTC_MAIN,
18+
CRTC_EXT,
19+
CRTC_THIRD,
20+
MAX_CRTC,
21+
};
22+
1723
struct device;
1824
struct device_node;
1925
struct drm_crtc;

0 commit comments

Comments
 (0)