dm: remove unnecessary (void*) conversions

yuzhenfschina · Mike Snitzer · commit 26cb62a28580 · 2023-04-11T12:01:01.000-04:00
Pointer variables of void * type do not require type cast.

Signed-off-by: Yu Zhe &lt;yuzhe@nfschina.com&gt;
Signed-off-by: Mike Snitzer &lt;snitzer@kernel.org&gt;
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
@@ -3118,7 +3118,7 @@ static int dm_integrity_reboot(struct notifier_block *n, unsigned long code, voi
 
 static void dm_integrity_postsuspend(struct dm_target *ti)
 {
-	struct dm_integrity_c *ic = (struct dm_integrity_c *)ti->private;
+	struct dm_integrity_c *ic = ti->private;
 	int r;
 
 	WARN_ON(unregister_reboot_notifier(&ic->reboot_notifier));
@@ -3167,7 +3167,7 @@ static void dm_integrity_postsuspend(struct dm_target *ti)
 
 static void dm_integrity_resume(struct dm_target *ti)
 {
-	struct dm_integrity_c *ic = (struct dm_integrity_c *)ti->private;
+	struct dm_integrity_c *ic = ti->private;
 	__u64 old_provided_data_sectors = le64_to_cpu(ic->sb->provided_data_sectors);
 	int r;
 
@@ -3290,7 +3290,7 @@ static void dm_integrity_resume(struct dm_target *ti)
 static void dm_integrity_status(struct dm_target *ti, status_type_t type,
 				unsigned int status_flags, char *result, unsigned int maxlen)
 {
-	struct dm_integrity_c *ic = (struct dm_integrity_c *)ti->private;
+	struct dm_integrity_c *ic = ti->private;
 	unsigned int arg_count;
 	size_t sz = 0;
 
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
@@ -187,7 +187,7 @@ static void list_get_page(struct dpages *dp,
 		  struct page **p, unsigned long *len, unsigned int *offset)
 {
 	unsigned int o = dp->context_u;
-	struct page_list *pl = (struct page_list *) dp->context_ptr;
+	struct page_list *pl = dp->context_ptr;
 
 	*p = pl->page;
 	*len = PAGE_SIZE - o;
@@ -196,7 +196,7 @@ static void list_get_page(struct dpages *dp,
 
 static void list_next_page(struct dpages *dp)
 {
-	struct page_list *pl = (struct page_list *) dp->context_ptr;
+	struct page_list *pl = dp->context_ptr;
 
 	dp->context_ptr = pl->next;
 	dp->context_u = 0;
diff --git a/drivers/md/dm-kcopyd.c b/drivers/md/dm-kcopyd.c
@@ -519,7 +519,7 @@ static int run_complete_job(struct kcopyd_job *job)
 
 static void complete_io(unsigned long error, void *context)
 {
-	struct kcopyd_job *job = (struct kcopyd_job *) context;
+	struct kcopyd_job *job = context;
 	struct dm_kcopyd_client *kc = job->kc;
 
 	io_job_finish(kc->throttle);
@@ -696,7 +696,7 @@ static void segment_complete(int read_err, unsigned long write_err,
 	/* FIXME: tidy this function */
 	sector_t progress = 0;
 	sector_t count = 0;
-	struct kcopyd_job *sub_job = (struct kcopyd_job *) context;
+	struct kcopyd_job *sub_job = context;
 	struct kcopyd_job *job = sub_job->master_job;
 	struct dm_kcopyd_client *kc = job->kc;
 
diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c
@@ -72,7 +72,7 @@ static int linear_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
 static void linear_dtr(struct dm_target *ti)
 {
-	struct linear_c *lc = (struct linear_c *) ti->private;
+	struct linear_c *lc = ti->private;
 
 	dm_put_device(ti, lc->dev);
 	kfree(lc);
@@ -98,7 +98,7 @@ static int linear_map(struct dm_target *ti, struct bio *bio)
 static void linear_status(struct dm_target *ti, status_type_t type,
 			  unsigned int status_flags, char *result, unsigned int maxlen)
 {
-	struct linear_c *lc = (struct linear_c *) ti->private;
+	struct linear_c *lc = ti->private;
 	size_t sz = 0;
 
 	switch (type) {
@@ -120,7 +120,7 @@ static void linear_status(struct dm_target *ti, status_type_t type,
 
 static int linear_prepare_ioctl(struct dm_target *ti, struct block_device **bdev)
 {
-	struct linear_c *lc = (struct linear_c *) ti->private;
+	struct linear_c *lc = ti->private;
 	struct dm_dev *dev = lc->dev;
 
 	*bdev = dev->bdev;
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
@@ -429,7 +429,7 @@ static inline sector_t logdev_last_sector(struct log_writes_c *lc)
 
 static int log_writes_kthread(void *arg)
 {
-	struct log_writes_c *lc = (struct log_writes_c *)arg;
+	struct log_writes_c *lc = arg;
 	sector_t sector = 0;
 
 	while (!kthread_should_stop()) {
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c
@@ -530,7 +530,7 @@ static void destroy_log_context(struct log_c *lc)
 
 static void core_dtr(struct dm_dirty_log *log)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	vfree(lc->clean_bits);
 	destroy_log_context(lc);
@@ -569,7 +569,7 @@ static int disk_ctr(struct dm_dirty_log *log, struct dm_target *ti,
 
 static void disk_dtr(struct dm_dirty_log *log)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	dm_put_device(lc->ti, lc->log_dev);
 	vfree(lc->disk_header);
@@ -590,7 +590,7 @@ static int disk_resume(struct dm_dirty_log *log)
 {
 	int r;
 	unsigned int i;
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 	size_t size = lc->bitset_uint32_count * sizeof(uint32_t);
 
 	/* read the disk header */
@@ -652,29 +652,29 @@ static int disk_resume(struct dm_dirty_log *log)
 
 static uint32_t core_get_region_size(struct dm_dirty_log *log)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	return lc->region_size;
 }
 
 static int core_resume(struct dm_dirty_log *log)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	lc->sync_search = 0;
 	return 0;
 }
 
 static int core_is_clean(struct dm_dirty_log *log, region_t region)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	return log_test_bit(lc->clean_bits, region);
 }
 
 static int core_in_sync(struct dm_dirty_log *log, region_t region, int block)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	return log_test_bit(lc->sync_bits, region);
 }
@@ -727,22 +727,22 @@ static int disk_flush(struct dm_dirty_log *log)
 
 static void core_mark_region(struct dm_dirty_log *log, region_t region)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	log_clear_bit(lc, lc->clean_bits, region);
 }
 
 static void core_clear_region(struct dm_dirty_log *log, region_t region)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	if (likely(!lc->flush_failed))
 		log_set_bit(lc, lc->clean_bits, region);
 }
 
 static int core_get_resync_work(struct dm_dirty_log *log, region_t *region)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	if (lc->sync_search >= lc->region_count)
 		return 0;
@@ -765,7 +765,7 @@ static int core_get_resync_work(struct dm_dirty_log *log, region_t *region)
 static void core_set_region_sync(struct dm_dirty_log *log, region_t region,
 				 int in_sync)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	log_clear_bit(lc, lc->recovering_bits, region);
 	if (in_sync) {
@@ -779,7 +779,7 @@ static void core_set_region_sync(struct dm_dirty_log *log, region_t region,
 
 static region_t core_get_sync_count(struct dm_dirty_log *log)
 {
-	struct log_c *lc = (struct log_c *) log->context;
+	struct log_c *lc = log->context;
 
 	return lc->sync_count;
 }
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
@@ -604,7 +604,7 @@ static void do_reads(struct mirror_set *ms, struct bio_list *reads)
 static void write_callback(unsigned long error, void *context)
 {
 	unsigned int i;
-	struct bio *bio = (struct bio *) context;
+	struct bio *bio = context;
 	struct mirror_set *ms;
 	int should_wake = 0;
 	unsigned long flags;
@@ -1180,7 +1180,7 @@ static int mirror_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 
 static void mirror_dtr(struct dm_target *ti)
 {
-	struct mirror_set *ms = (struct mirror_set *) ti->private;
+	struct mirror_set *ms = ti->private;
 
 	del_timer_sync(&ms->timer);
 	flush_workqueue(ms->kmirrord_wq);
@@ -1246,7 +1246,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio,
 		blk_status_t *error)
 {
 	int rw = bio_data_dir(bio);
-	struct mirror_set *ms = (struct mirror_set *) ti->private;
+	struct mirror_set *ms = ti->private;
 	struct mirror *m = NULL;
 	struct dm_bio_details *bd = NULL;
 	struct dm_raid1_bio_record *bio_record =
@@ -1311,7 +1311,7 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio,
 
 static void mirror_presuspend(struct dm_target *ti)
 {
-	struct mirror_set *ms = (struct mirror_set *) ti->private;
+	struct mirror_set *ms = ti->private;
 	struct dm_dirty_log *log = dm_rh_dirty_log(ms->rh);
 
 	struct bio_list holds;
@@ -1407,7 +1407,7 @@ static void mirror_status(struct dm_target *ti, status_type_t type,
 {
 	unsigned int m, sz = 0;
 	int num_feature_args = 0;
-	struct mirror_set *ms = (struct mirror_set *) ti->private;
+	struct mirror_set *ms = ti->private;
 	struct dm_dirty_log *log = dm_rh_dirty_log(ms->rh);
 	char buffer[MAX_NR_MIRRORS + 1];
 
diff --git a/drivers/md/dm-snap-persistent.c b/drivers/md/dm-snap-persistent.c
@@ -567,7 +567,7 @@ static int read_exceptions(struct pstore *ps,
 
 static struct pstore *get_info(struct dm_exception_store *store)
 {
-	return (struct pstore *) store->context;
+	return store->context;
 }
 
 static void persistent_usage(struct dm_exception_store *store,
diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
@@ -189,7 +189,7 @@ static int stripe_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 static void stripe_dtr(struct dm_target *ti)
 {
 	unsigned int i;
-	struct stripe_c *sc = (struct stripe_c *) ti->private;
+	struct stripe_c *sc = ti->private;
 
 	for (i = 0; i < sc->stripes; i++)
 		dm_put_device(ti, sc->stripe[i].dev);
@@ -360,7 +360,7 @@ static size_t stripe_dax_recovery_write(struct dm_target *ti, pgoff_t pgoff,
 static void stripe_status(struct dm_target *ti, status_type_t type,
 			  unsigned int status_flags, char *result, unsigned int maxlen)
 {
-	struct stripe_c *sc = (struct stripe_c *) ti->private;
+	struct stripe_c *sc = ti->private;
 	unsigned int sz = 0;
 	unsigned int i;
 
diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c
@@ -567,14 +567,14 @@ void verity_fec_dtr(struct dm_verity *v)
 
 static void *fec_rs_alloc(gfp_t gfp_mask, void *pool_data)
 {
-	struct dm_verity *v = (struct dm_verity *)pool_data;
+	struct dm_verity *v = pool_data;
 
 	return init_rs_gfp(8, 0x11d, 0, 1, v->fec->roots, gfp_mask);
 }
 
 static void fec_rs_free(void *element, void *pool_data)
 {
-	struct rs_control *rs = (struct rs_control *)element;
+	struct rs_control *rs = element;
 
 	if (rs)
 		free_rs(rs);
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
@@ -1701,7 +1701,7 @@ static int dmz_load_mapping(struct dmz_metadata *zmd)
 			if (IS_ERR(dmap_mblk))
 				return PTR_ERR(dmap_mblk);
 			zmd->map_mblk[i] = dmap_mblk;
-			dmap = (struct dmz_map *) dmap_mblk->data;
+			dmap = dmap_mblk->data;
 			i++;
 			e = 0;
 		}
@@ -1832,7 +1832,7 @@ static void dmz_set_chunk_mapping(struct dmz_metadata *zmd, unsigned int chunk,
 				  unsigned int dzone_id, unsigned int bzone_id)
 {
 	struct dmz_mblock *dmap_mblk = zmd->map_mblk[chunk >> DMZ_MAP_ENTRIES_SHIFT];
-	struct dmz_map *dmap = (struct dmz_map *) dmap_mblk->data;
+	struct dmz_map *dmap = dmap_mblk->data;
 	int map_idx = chunk & DMZ_MAP_ENTRIES_MASK;
 
 	dmap[map_idx].dzone_id = cpu_to_le32(dzone_id);
@@ -2045,7 +2045,7 @@ struct dm_zone *dmz_get_chunk_mapping(struct dmz_metadata *zmd,
 				      unsigned int chunk, enum req_op op)
 {
 	struct dmz_mblock *dmap_mblk = zmd->map_mblk[chunk >> DMZ_MAP_ENTRIES_SHIFT];
-	struct dmz_map *dmap = (struct dmz_map *) dmap_mblk->data;
+	struct dmz_map *dmap = dmap_mblk->data;
 	int dmap_idx = chunk & DMZ_MAP_ENTRIES_MASK;
 	unsigned int dzone_id;
 	struct dm_zone *dzone = NULL;

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ static void list_get_page(struct dpages *dp,`
`187`	`187`	`struct page *p, unsigned long len, unsigned int *offset)`
`188`	`188`	`{`
`189`	`189`	`unsigned int o = dp->context_u;`
`190`		`- struct page_list pl = (struct page_list ) dp->context_ptr;`
	`190`	`+ struct page_list *pl = dp->context_ptr;`
`191`	`191`
`192`	`192`	`*p = pl->page;`
`193`	`193`	`*len = PAGE_SIZE - o;`
`@@ -196,7 +196,7 @@ static void list_get_page(struct dpages *dp,`
`196`	`196`
`197`	`197`	`static void list_next_page(struct dpages *dp)`
`198`	`198`	`{`
`199`		`- struct page_list pl = (struct page_list ) dp->context_ptr;`
	`199`	`+ struct page_list *pl = dp->context_ptr;`
`200`	`200`
`201`	`201`	`dp->context_ptr = pl->next;`
`202`	`202`	`dp->context_u = 0;`
Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ static inline sector_t logdev_last_sector(struct log_writes_c *lc)`
`429`	`429`
`430`	`430`	`static int log_writes_kthread(void *arg)`
`431`	`431`	`{`
`432`		`- struct log_writes_c lc = (struct log_writes_c )arg;`
	`432`	`+ struct log_writes_c *lc = arg;`
`433`	`433`	`sector_t sector = 0;`
`434`	`434`
`435`	`435`	`while (!kthread_should_stop()) {`
Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,7 @@ static void destroy_log_context(struct log_c *lc)`
`530`	`530`
`531`	`531`	`static void core_dtr(struct dm_dirty_log *log)`
`532`	`532`	`{`
`533`		`- struct log_c lc = (struct log_c ) log->context;`
	`533`	`+ struct log_c *lc = log->context;`
`534`	`534`
`535`	`535`	`vfree(lc->clean_bits);`
`536`	`536`	`destroy_log_context(lc);`
`@@ -569,7 +569,7 @@ static int disk_ctr(struct dm_dirty_log log, struct dm_target ti,`
`569`	`569`
`570`	`570`	`static void disk_dtr(struct dm_dirty_log *log)`
`571`	`571`	`{`
`572`		`- struct log_c lc = (struct log_c ) log->context;`
	`572`	`+ struct log_c *lc = log->context;`
`573`	`573`
`574`	`574`	`dm_put_device(lc->ti, lc->log_dev);`
`575`	`575`	`vfree(lc->disk_header);`
`@@ -590,7 +590,7 @@ static int disk_resume(struct dm_dirty_log *log)`
`590`	`590`	`{`
`591`	`591`	`int r;`
`592`	`592`	`unsigned int i;`
`593`		`- struct log_c lc = (struct log_c ) log->context;`
	`593`	`+ struct log_c *lc = log->context;`
`594`	`594`	`size_t size = lc->bitset_uint32_count * sizeof(uint32_t);`
`595`	`595`
`596`	`596`	`/* read the disk header */`
`@@ -652,29 +652,29 @@ static int disk_resume(struct dm_dirty_log *log)`
`652`	`652`
`653`	`653`	`static uint32_t core_get_region_size(struct dm_dirty_log *log)`
`654`	`654`	`{`
`655`		`- struct log_c lc = (struct log_c ) log->context;`
	`655`	`+ struct log_c *lc = log->context;`
`656`	`656`
`657`	`657`	`return lc->region_size;`
`658`	`658`	`}`
`659`	`659`
`660`	`660`	`static int core_resume(struct dm_dirty_log *log)`
`661`	`661`	`{`
`662`		`- struct log_c lc = (struct log_c ) log->context;`
	`662`	`+ struct log_c *lc = log->context;`
`663`	`663`
`664`	`664`	`lc->sync_search = 0;`
`665`	`665`	`return 0;`
`666`	`666`	`}`
`667`	`667`
`668`	`668`	`static int core_is_clean(struct dm_dirty_log *log, region_t region)`
`669`	`669`	`{`
`670`		`- struct log_c lc = (struct log_c ) log->context;`
	`670`	`+ struct log_c *lc = log->context;`
`671`	`671`
`672`	`672`	`return log_test_bit(lc->clean_bits, region);`
`673`	`673`	`}`
`674`	`674`
`675`	`675`	`static int core_in_sync(struct dm_dirty_log *log, region_t region, int block)`
`676`	`676`	`{`
`677`		`- struct log_c lc = (struct log_c ) log->context;`
	`677`	`+ struct log_c *lc = log->context;`
`678`	`678`
`679`	`679`	`return log_test_bit(lc->sync_bits, region);`
`680`	`680`	`}`
`@@ -727,22 +727,22 @@ static int disk_flush(struct dm_dirty_log *log)`
`727`	`727`
`728`	`728`	`static void core_mark_region(struct dm_dirty_log *log, region_t region)`
`729`	`729`	`{`
`730`		`- struct log_c lc = (struct log_c ) log->context;`
	`730`	`+ struct log_c *lc = log->context;`
`731`	`731`
`732`	`732`	`log_clear_bit(lc, lc->clean_bits, region);`
`733`	`733`	`}`
`734`	`734`
`735`	`735`	`static void core_clear_region(struct dm_dirty_log *log, region_t region)`
`736`	`736`	`{`
`737`		`- struct log_c lc = (struct log_c ) log->context;`
	`737`	`+ struct log_c *lc = log->context;`
`738`	`738`
`739`	`739`	`if (likely(!lc->flush_failed))`
`740`	`740`	`log_set_bit(lc, lc->clean_bits, region);`
`741`	`741`	`}`
`742`	`742`
`743`	`743`	`static int core_get_resync_work(struct dm_dirty_log log, region_t region)`
`744`	`744`	`{`
`745`		`- struct log_c lc = (struct log_c ) log->context;`
	`745`	`+ struct log_c *lc = log->context;`
`746`	`746`
`747`	`747`	`if (lc->sync_search >= lc->region_count)`
`748`	`748`	`return 0;`
`@@ -765,7 +765,7 @@ static int core_get_resync_work(struct dm_dirty_log log, region_t region)`
`765`	`765`	`static void core_set_region_sync(struct dm_dirty_log *log, region_t region,`
`766`	`766`	`int in_sync)`
`767`	`767`	`{`
`768`		`- struct log_c lc = (struct log_c ) log->context;`
	`768`	`+ struct log_c *lc = log->context;`
`769`	`769`
`770`	`770`	`log_clear_bit(lc, lc->recovering_bits, region);`
`771`	`771`	`if (in_sync) {`
`@@ -779,7 +779,7 @@ static void core_set_region_sync(struct dm_dirty_log *log, region_t region,`
`779`	`779`
`780`	`780`	`static region_t core_get_sync_count(struct dm_dirty_log *log)`
`781`	`781`	`{`
`782`		`- struct log_c lc = (struct log_c ) log->context;`
	`782`	`+ struct log_c *lc = log->context;`
`783`	`783`
`784`	`784`	`return lc->sync_count;`
`785`	`785`	`}`
Original file line number	Diff line number	Diff line change
`@@ -567,7 +567,7 @@ static int read_exceptions(struct pstore *ps,`
`567`	`567`
`568`	`568`	`static struct pstore get_info(struct dm_exception_store store)`
`569`	`569`	`{`
`570`		`- return (struct pstore *) store->context;`
	`570`	`+ return store->context;`
`571`	`571`	`}`
`572`	`572`
`573`	`573`	`static void persistent_usage(struct dm_exception_store *store,`
Original file line number	Diff line number	Diff line change
`@@ -567,14 +567,14 @@ void verity_fec_dtr(struct dm_verity *v)`
`567`	`567`
`568`	`568`	`static void fec_rs_alloc(gfp_t gfp_mask, void pool_data)`
`569`	`569`	`{`
`570`		`- struct dm_verity v = (struct dm_verity )pool_data;`
	`570`	`+ struct dm_verity *v = pool_data;`
`571`	`571`
`572`	`572`	`return init_rs_gfp(8, 0x11d, 0, 1, v->fec->roots, gfp_mask);`
`573`	`573`	`}`
`574`	`574`
`575`	`575`	`static void fec_rs_free(void element, void pool_data)`
`576`	`576`	`{`
`577`		`- struct rs_control rs = (struct rs_control )element;`
	`577`	`+ struct rs_control *rs = element;`
`578`	`578`
`579`	`579`	`if (rs)`
`580`	`580`	`free_rs(rs);`