Skip to content

Commit 2704b2d

Browse files
ij-intelshuahkh
authored andcommitted
selftests/resctrl: Make "bandwidth" consistent in comments & prints
Resctrl selftests refer to "bandwidth" currently in two other forms in the code ("B/W" and "band width"). Use "bandwidth" consistently everywhere. While at it, fix also one "over flow" -> "overflow" on a line that is touched by the change. Suggested-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Tested-by: Babu Moger <babu.moger@amd.com> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent da50de0 commit 2704b2d

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

tools/testing/selftests/resctrl/resctrl_val.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,11 @@ static void do_imc_mem_bw_test(void)
361361
}
362362

363363
/*
364-
* get_mem_bw_imc - Memory band width as reported by iMC counters
364+
* get_mem_bw_imc - Memory bandwidth as reported by iMC counters
365365
* @bw_report: Bandwidth report type (reads, writes)
366366
*
367-
* Memory B/W utilized by a process on a socket can be calculated using
368-
* iMC counters. Perf events are used to read these counters.
367+
* Memory bandwidth utilized by a process on a socket can be calculated
368+
* using iMC counters. Perf events are used to read these counters.
369369
*
370370
* Return: = 0 on success. < 0 on failure.
371371
*/
@@ -379,7 +379,7 @@ static int get_mem_bw_imc(char *bw_report, float *bw_imc)
379379

380380
/*
381381
* Get results which are stored in struct type imc_counter_config
382-
* Take over flow into consideration before calculating total b/w
382+
* Take overflow into consideration before calculating total bandwidth.
383383
*/
384384
for (imc = 0; imc < imcs; imc++) {
385385
struct imc_counter_config *r =
@@ -389,13 +389,13 @@ static int get_mem_bw_imc(char *bw_report, float *bw_imc)
389389

390390
if (read(r->fd, &r->return_value,
391391
sizeof(struct membw_read_format)) == -1) {
392-
ksft_perror("Couldn't get read b/w through iMC");
392+
ksft_perror("Couldn't get read bandwidth through iMC");
393393
return -1;
394394
}
395395

396396
if (read(w->fd, &w->return_value,
397397
sizeof(struct membw_read_format)) == -1) {
398-
ksft_perror("Couldn't get write bw through iMC");
398+
ksft_perror("Couldn't get write bandwidth through iMC");
399399
return -1;
400400
}
401401

@@ -492,7 +492,7 @@ static FILE *open_mem_bw_resctrl(const char *mbm_bw_file)
492492

493493
fp = fopen(mbm_bw_file, "r");
494494
if (!fp)
495-
ksft_perror("Failed to open total bw file");
495+
ksft_perror("Failed to open total memory bandwidth file");
496496

497497
return fp;
498498
}

tools/testing/selftests/resctrl/resctrlfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ int validate_bw_report_request(char *bw_report)
850850
if (strcmp(bw_report, "total") == 0)
851851
return 0;
852852

853-
fprintf(stderr, "Requested iMC B/W report type unavailable\n");
853+
fprintf(stderr, "Requested iMC bandwidth report type unavailable\n");
854854

855855
return -1;
856856
}

0 commit comments

Comments
 (0)