Skip to content

Commit 272377a

Browse files
nfrapradorobertfoss
authored andcommitted
drm/bridge: tc358775: Don't log an error when DSI host can't be found
Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: b269755 ("display/drm/bridge: TC358775 DSI/LVDS driver") Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-6-619a28148e5c@collabora.com
1 parent 6d9e877 commit 272377a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/gpu/drm/bridge/tc358775.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -610,10 +610,8 @@ static int tc_attach_host(struct tc_data *tc)
610610
};
611611

612612
host = of_find_mipi_dsi_host_by_node(tc->host_node);
613-
if (!host) {
614-
dev_err(dev, "failed to find dsi host\n");
615-
return -EPROBE_DEFER;
616-
}
613+
if (!host)
614+
return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
617615

618616
dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
619617
if (IS_ERR(dsi)) {

0 commit comments

Comments
 (0)