Skip to content

Commit 274d937

Browse files
committed
pseries: convert papr_platform_dump_create_handle() to FD_ADD()
Link: https://patch.msgid.link/20251123-work-fd-prepare-v4-35-b6efa1706cfd@kernel.org Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 0b9d4a6 commit 274d937

1 file changed

Lines changed: 8 additions & 22 deletions

File tree

arch/powerpc/platforms/pseries/papr-platform-dump.c

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,6 @@ static long papr_platform_dump_create_handle(u64 dump_tag)
303303
{
304304
struct ibm_platform_dump_params *params;
305305
u64 param_dump_tag;
306-
struct file *file;
307-
long err;
308306
int fd;
309307

310308
/*
@@ -334,34 +332,22 @@ static long papr_platform_dump_create_handle(u64 dump_tag)
334332
params->dump_tag_lo = (u32)(dump_tag & 0x00000000ffffffffULL);
335333
params->status = RTAS_IBM_PLATFORM_DUMP_START;
336334

337-
fd = get_unused_fd_flags(O_RDONLY | O_CLOEXEC);
335+
fd = FD_ADD(O_RDONLY | O_CLOEXEC,
336+
anon_inode_getfile_fmode("[papr-platform-dump]",
337+
&papr_platform_dump_handle_ops,
338+
(void *)params, O_RDONLY,
339+
FMODE_LSEEK | FMODE_PREAD));
338340
if (fd < 0) {
339-
err = fd;
340-
goto free_area;
341-
}
342-
343-
file = anon_inode_getfile_fmode("[papr-platform-dump]",
344-
&papr_platform_dump_handle_ops,
345-
(void *)params, O_RDONLY,
346-
FMODE_LSEEK | FMODE_PREAD);
347-
if (IS_ERR(file)) {
348-
err = PTR_ERR(file);
349-
goto put_fd;
341+
rtas_work_area_free(params->work_area);
342+
kfree(params);
343+
return fd;
350344
}
351345

352-
fd_install(fd, file);
353-
354346
list_add(&params->list, &platform_dump_list);
355347

356348
pr_info("%s (%d) initiated platform dump for dump tag %llu\n",
357349
current->comm, current->pid, dump_tag);
358350
return fd;
359-
put_fd:
360-
put_unused_fd(fd);
361-
free_area:
362-
rtas_work_area_free(params->work_area);
363-
kfree(params);
364-
return err;
365351
}
366352

367353
/*

0 commit comments

Comments
 (0)