Skip to content

Commit 27aff0a

Browse files
Marnix Rijnartgregkh
authored andcommitted
serial: 8250_pci: Fix broken RS485 for F81504/508/512
Fintek F81504/508/512 can support both RTS_ON_SEND and RTS_AFTER_SEND, but pci_fintek_rs485_supported only announces the former. This makes it impossible to unset SER_RS485_RTS_ON_SEND from userspace because of uart_sanitize_serial_rs485(). Some devices with these chips need RTS low on TX, so they are effectively broken. Fix this by announcing the support for SER_RS485_RTS_AFTER_SEND, similar to commit 068d35a ("serial: sc16is7xx: announce support for SER_RS485_RTS_ON_SEND"). Fixes: 4afeced ("serial: core: fix sanitizing check for RTS settings") Cc: stable <stable@kernel.org> Signed-off-by: Marnix Rijnart <marnix.rijnart@iwell.eu> Link: https://patch.msgid.link/20260112000931.61703-1-marnix.rijnart@iwell.eu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fb47423 commit 27aff0a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/serial/8250/8250_pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1658,7 +1658,7 @@ static int pci_fintek_rs485_config(struct uart_port *port, struct ktermios *term
16581658
}
16591659

16601660
static const struct serial_rs485 pci_fintek_rs485_supported = {
1661-
.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND,
1661+
.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND,
16621662
/* F81504/508/512 does not support RTS delay before or after send */
16631663
};
16641664

0 commit comments

Comments
 (0)