Skip to content

Commit 27db47a

Browse files
ryderlee1110nbd168
authored andcommitted
wifi: mt76: mt7996: enable mesh HW amsdu/de-amsdu support
This enables HW offloading amsdu/de-amsdu support for 802.11s mesh interface. Co-developed-by: Bo Jiao <bo.jiao@mediatek.com> Signed-off-by: Bo Jiao <bo.jiao@mediatek.com> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent c2171b0 commit 27db47a

5 files changed

Lines changed: 27 additions & 9 deletions

File tree

drivers/net/wireless/mediatek/mt76/mt7996/mac.c

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -641,6 +641,8 @@ mt7996_mac_fill_rx(struct mt7996_dev *dev, struct sk_buff *skb)
641641
u32 rxd4 = le32_to_cpu(rxd[4]);
642642
u32 csum_mask = MT_RXD0_NORMAL_IP_SUM | MT_RXD0_NORMAL_UDP_TCP_SUM;
643643
u32 csum_status = *(u32 *)skb->cb;
644+
u32 mesh_mask = MT_RXD0_MESH | MT_RXD0_MHCP;
645+
bool is_mesh = (rxd0 & mesh_mask) == mesh_mask;
644646
bool unicast, insert_ccmp_hdr = false;
645647
u8 remove_pad, amsdu_info, band_idx;
646648
u8 mode = 0, qos_ctl = 0;
@@ -832,19 +834,16 @@ mt7996_mac_fill_rx(struct mt7996_dev *dev, struct sk_buff *skb)
832834
int pad_start = 0;
833835

834836
skb_pull(skb, hdr_gap);
835-
if (!hdr_trans && status->amsdu) {
837+
if (!hdr_trans && status->amsdu && !(ieee80211_has_a4(fc) && is_mesh)) {
836838
pad_start = ieee80211_get_hdrlen_from_skb(skb);
837-
} else if (hdr_trans && (rxd2 & MT_RXD2_NORMAL_HDR_TRANS_ERROR)) {
839+
} else if (hdr_trans && (rxd2 & MT_RXD2_NORMAL_HDR_TRANS_ERROR) &&
840+
get_unaligned_be16(skb->data + pad_start) == ETH_P_8021Q) {
838841
/* When header translation failure is indicated,
839842
* the hardware will insert an extra 2-byte field
840843
* containing the data length after the protocol
841844
* type field.
842845
*/
843-
pad_start = 12;
844-
if (get_unaligned_be16(skb->data + pad_start) == ETH_P_8021Q)
845-
pad_start += 4;
846-
else
847-
pad_start = 0;
846+
pad_start = 16;
848847
}
849848

850849
if (pad_start) {
@@ -865,8 +864,17 @@ mt7996_mac_fill_rx(struct mt7996_dev *dev, struct sk_buff *skb)
865864
hdr = mt76_skb_get_hdr(skb);
866865
fc = hdr->frame_control;
867866
if (ieee80211_is_data_qos(fc)) {
867+
u8 *qos = ieee80211_get_qos_ctl(hdr);
868+
868869
seq_ctrl = le16_to_cpu(hdr->seq_ctrl);
869-
qos_ctl = *ieee80211_get_qos_ctl(hdr);
870+
qos_ctl = *qos;
871+
872+
/* Mesh DA/SA/Length will be stripped after hardware
873+
* de-amsdu, so here needs to clear amsdu present bit
874+
* to mark it as a normal mesh frame.
875+
*/
876+
if (ieee80211_has_a4(fc) && is_mesh && status->amsdu)
877+
*qos &= ~IEEE80211_QOS_CTL_A_MSDU_PRESENT;
870878
}
871879
} else {
872880
status->flag |= RX_FLAG_8023;

drivers/net/wireless/mediatek/mt76/mt7996/mac.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
#define MT_RXD0_LENGTH GENMASK(15, 0)
1313
#define MT_RXD0_PKT_TYPE GENMASK(31, 27)
1414

15+
#define MT_RXD0_MESH BIT(18)
16+
#define MT_RXD0_MHCP BIT(19)
1517
#define MT_RXD0_NORMAL_ETH_TYPE_OFS GENMASK(22, 16)
1618
#define MT_RXD0_NORMAL_IP_SUM BIT(23)
1719
#define MT_RXD0_NORMAL_UDP_TCP_SUM BIT(24)

drivers/net/wireless/mediatek/mt76/mt7996/mcu.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,6 +1022,7 @@ mt7996_mcu_sta_amsdu_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
10221022
struct tlv *tlv;
10231023

10241024
if (vif->type != NL80211_IFTYPE_STATION &&
1025+
vif->type != NL80211_IFTYPE_MESH_POINT &&
10251026
vif->type != NL80211_IFTYPE_AP)
10261027
return;
10271028

@@ -1470,6 +1471,12 @@ mt7996_mcu_sta_hdr_trans_tlv(struct mt7996_dev *dev, struct sk_buff *skb,
14701471
hdr_trans->to_ds = true;
14711472
hdr_trans->from_ds = true;
14721473
}
1474+
1475+
if (vif->type == NL80211_IFTYPE_MESH_POINT) {
1476+
hdr_trans->to_ds = true;
1477+
hdr_trans->from_ds = true;
1478+
hdr_trans->mesh = true;
1479+
}
14731480
}
14741481

14751482
static enum mcu_mmps_mode

drivers/net/wireless/mediatek/mt76/mt7996/mcu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ struct sta_rec_hdr_trans {
396396
u8 from_ds;
397397
u8 to_ds;
398398
u8 dis_rx_hdr_tran;
399-
u8 rsv;
399+
u8 mesh;
400400
} __packed;
401401

402402
struct hdr_trans_en {

drivers/net/wireless/mediatek/mt76/mt7996/mmio.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ struct mt7996_dev *mt7996_mmio_probe(struct device *pdev,
327327
/* txwi_size = txd size + txp size */
328328
.txwi_size = MT_TXD_SIZE + sizeof(struct mt76_connac_fw_txp),
329329
.drv_flags = MT_DRV_TXWI_NO_FREE |
330+
MT_DRV_AMSDU_OFFLOAD |
330331
MT_DRV_HW_MGMT_TXQ,
331332
.survey_flags = SURVEY_INFO_TIME_TX |
332333
SURVEY_INFO_TIME_RX |

0 commit comments

Comments
 (0)