Skip to content

Commit 27e6953

Browse files
nfrapradoAngeloGioacchino Del Regno
authored andcommitted
soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found
Most of the callers to this function do not require CMDQ support, it is optional, so the missing property shouldn't cause an error message. However, it could result on degraded performance, so the fact that it's missing should still be alerted. Furthermore, the callers that do require CMDQ support already log at the error level when an error is returned. Change the log message in this helper to be printed at the warning level instead. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20240229-gce-client-reg-log-dbg-v2-1-4975077173d0@collabora.com Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
1 parent 69ff683 commit 27e6953

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/soc/mediatek/mtk-cmdq-helper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ int cmdq_dev_get_client_reg(struct device *dev,
5858
"mediatek,gce-client-reg",
5959
3, idx, &spec);
6060
if (err < 0) {
61-
dev_err(dev,
61+
dev_warn(dev,
6262
"error %d can't parse gce-client-reg property (%d)",
6363
err, idx);
6464

0 commit comments

Comments
 (0)