Skip to content

Commit 287a344

Browse files
shenkiLinus Walleij
authored andcommitted
pinctrl: aspeed: Fix confusing types in return value
The function signature is int, but we return a bool. Instead return a negative errno as the kerneldoc suggests. Fixes: 4d3d0e4 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Andrew Jeffery <andrew@aj.id.au> Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 5754a1c commit 287a344

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/pinctrl/aspeed/pinctrl-aspeed.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
114114
int ret = 0;
115115

116116
if (!exprs)
117-
return true;
117+
return -EINVAL;
118118

119119
while (*exprs && !ret) {
120120
ret = aspeed_sig_expr_disable(ctx, *exprs);

0 commit comments

Comments
 (0)