Skip to content

Commit 28da4f8

Browse files
committed
drm/i915/dp: stop caching has_audio in struct intel_dp
Use the information stored in display info. Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/695bbe8b5ebee6e492f95a1c818da15691752dc8.1685437500.git.jani.nikula@intel.com
1 parent 3d35ddf commit 28da4f8

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

drivers/gpu/drm/i915/display/intel_display_debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ static void intel_dp_info(struct seq_file *m,
237237

238238
seq_printf(m, "\tDPCD rev: %x\n", intel_dp->dpcd[DP_DPCD_REV]);
239239
seq_printf(m, "\taudio support: %s\n",
240-
str_yes_no(intel_dp->has_audio));
240+
str_yes_no(intel_connector->base.display_info.has_audio));
241241

242242
drm_dp_downstream_debug(m, intel_dp->dpcd, intel_dp->downstream_ports,
243243
edid ? edid->data : NULL, &intel_dp->aux);

drivers/gpu/drm/i915/display/intel_display_types.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1708,7 +1708,6 @@ struct intel_dp {
17081708
u8 sink_count;
17091709
bool link_trained;
17101710
bool has_hdmi_sink;
1711-
bool has_audio;
17121711
bool reset_link_params;
17131712
bool use_max_params;
17141713
u8 dpcd[DP_RECEIVER_CAP_SIZE];

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2159,14 +2159,15 @@ static bool intel_dp_has_audio(struct intel_encoder *encoder,
21592159
{
21602160
struct drm_i915_private *i915 = to_i915(encoder->base.dev);
21612161
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
2162+
struct intel_connector *connector = intel_dp->attached_connector;
21622163
const struct intel_digital_connector_state *intel_conn_state =
21632164
to_intel_digital_connector_state(conn_state);
21642165

21652166
if (!intel_dp_port_has_audio(i915, encoder->port))
21662167
return false;
21672168

21682169
if (intel_conn_state->force_audio == HDMI_AUDIO_AUTO)
2169-
return intel_dp->has_audio;
2170+
return connector->base.display_info.has_audio;
21702171
else
21712172
return intel_conn_state->force_audio == HDMI_AUDIO_ON;
21722173
}
@@ -4813,7 +4814,6 @@ intel_dp_set_edid(struct intel_dp *intel_dp)
48134814
edid = drm_edid_raw(drm_edid);
48144815
if (edid && edid->input & DRM_EDID_INPUT_DIGITAL) {
48154816
intel_dp->has_hdmi_sink = drm_detect_hdmi_monitor(edid);
4816-
intel_dp->has_audio = drm_detect_monitor_audio(edid);
48174817
}
48184818

48194819
drm_dp_cec_set_edid(&intel_dp->aux, edid);
@@ -4829,7 +4829,6 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
48294829
connector->detect_edid = NULL;
48304830

48314831
intel_dp->has_hdmi_sink = false;
4832-
intel_dp->has_audio = false;
48334832

48344833
intel_dp->dfp.max_bpc = 0;
48354834
intel_dp->dfp.max_dotclock = 0;

0 commit comments

Comments
 (0)