Skip to content

Commit 28ee08c

Browse files
cristiccmmind
authored andcommitted
arm64: dts: rockchip: Assign ES8316 MCLK rate on rk3588-rock-5b
The I2S0_8CH_MCLKOUT clock rate on Rock 5B board defaults to 12 MHz and it is used to provide the master clock (MCLK) for the ES8316 audio codec. On sound card initialization, this limits the allowed sample rates according to the MCLK/LRCK ratios supported by the codec, which results in the following non-standard rates: 15625, 30000, 31250, 46875. Hence, the very first access of the sound card fails: Broken configuration for playback: no configurations available: Invalid argument Setting of hwparams failed: Invalid argument However, all subsequent attempts will succeed, as the audio graph card will request a correct clock frequency, based on the stream sample rate and the multiplication factor. Assign MCLK to 12.288 MHz, which allows the codec to advertise most of the standard sample rates. Fixes: 55529fe ("arm64: dts: rockchip: Add rk3588-rock-5b analog audio") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Link: https://lore.kernel.org/r/20230530181140.483936-4-cristian.ciocaltea@collabora.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
1 parent 3900160 commit 28ee08c

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,8 @@
133133
reg = <0x11>;
134134
clocks = <&cru I2S0_8CH_MCLKOUT>;
135135
clock-names = "mclk";
136+
assigned-clocks = <&cru I2S0_8CH_MCLKOUT>;
137+
assigned-clock-rates = <12288000>;
136138
#sound-dai-cells = <0>;
137139

138140
port {

0 commit comments

Comments
 (0)