Skip to content

Commit 28ee0ec

Browse files
committed
svcrdma: De-duplicate completion ID initialization helpers
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 018f340 commit 28ee0ec

4 files changed

Lines changed: 25 additions & 22 deletions

File tree

include/linux/sunrpc/svc_rdma.h

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,30 @@ enum {
134134

135135
#define RPCSVC_MAXPAYLOAD_RDMA RPCSVC_MAXPAYLOAD
136136

137+
/**
138+
* svc_rdma_send_cid_init - Initialize a Receive Queue completion ID
139+
* @rdma: controlling transport
140+
* @cid: completion ID to initialize
141+
*/
142+
static inline void svc_rdma_recv_cid_init(struct svcxprt_rdma *rdma,
143+
struct rpc_rdma_cid *cid)
144+
{
145+
cid->ci_queue_id = rdma->sc_rq_cq->res.id;
146+
cid->ci_completion_id = atomic_inc_return(&rdma->sc_completion_ids);
147+
}
148+
149+
/**
150+
* svc_rdma_send_cid_init - Initialize a Send Queue completion ID
151+
* @rdma: controlling transport
152+
* @cid: completion ID to initialize
153+
*/
154+
static inline void svc_rdma_send_cid_init(struct svcxprt_rdma *rdma,
155+
struct rpc_rdma_cid *cid)
156+
{
157+
cid->ci_queue_id = rdma->sc_sq_cq->res.id;
158+
cid->ci_completion_id = atomic_inc_return(&rdma->sc_completion_ids);
159+
}
160+
137161
/*
138162
* A chunk context tracks all I/O for moving one Read or Write
139163
* chunk. This is a set of rdma_rw's that handle data movement

net/sunrpc/xprtrdma/svc_rdma_recvfrom.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,13 +115,6 @@ svc_rdma_next_recv_ctxt(struct list_head *list)
115115
rc_list);
116116
}
117117

118-
static void svc_rdma_recv_cid_init(struct svcxprt_rdma *rdma,
119-
struct rpc_rdma_cid *cid)
120-
{
121-
cid->ci_queue_id = rdma->sc_rq_cq->res.id;
122-
cid->ci_completion_id = atomic_inc_return(&rdma->sc_completion_ids);
123-
}
124-
125118
static struct svc_rdma_recv_ctxt *
126119
svc_rdma_recv_ctxt_alloc(struct svcxprt_rdma *rdma)
127120
{

net/sunrpc/xprtrdma/svc_rdma_rw.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,6 @@ static int svc_rdma_rw_ctx_init(struct svcxprt_rdma *rdma,
146146
return ret;
147147
}
148148

149-
static void svc_rdma_cc_cid_init(struct svcxprt_rdma *rdma,
150-
struct rpc_rdma_cid *cid)
151-
{
152-
cid->ci_queue_id = rdma->sc_sq_cq->res.id;
153-
cid->ci_completion_id = atomic_inc_return(&rdma->sc_completion_ids);
154-
}
155-
156149
/**
157150
* svc_rdma_cc_init - Initialize an svc_rdma_chunk_ctxt
158151
* @rdma: controlling transport instance
@@ -161,7 +154,7 @@ static void svc_rdma_cc_cid_init(struct svcxprt_rdma *rdma,
161154
void svc_rdma_cc_init(struct svcxprt_rdma *rdma,
162155
struct svc_rdma_chunk_ctxt *cc)
163156
{
164-
svc_rdma_cc_cid_init(rdma, &cc->cc_cid);
157+
svc_rdma_send_cid_init(rdma, &cc->cc_cid);
165158

166159
INIT_LIST_HEAD(&cc->cc_rwctxts);
167160
cc->cc_sqecount = 0;

net/sunrpc/xprtrdma/svc_rdma_sendto.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@
113113

114114
static void svc_rdma_wc_send(struct ib_cq *cq, struct ib_wc *wc);
115115

116-
static void svc_rdma_send_cid_init(struct svcxprt_rdma *rdma,
117-
struct rpc_rdma_cid *cid)
118-
{
119-
cid->ci_queue_id = rdma->sc_sq_cq->res.id;
120-
cid->ci_completion_id = atomic_inc_return(&rdma->sc_completion_ids);
121-
}
122-
123116
static struct svc_rdma_send_ctxt *
124117
svc_rdma_send_ctxt_alloc(struct svcxprt_rdma *rdma)
125118
{

0 commit comments

Comments
 (0)