Skip to content

Commit 2917406

Browse files
Barry SongPeter Zijlstra
authored andcommitted
sched/fair: Document the slow path and fast path in select_task_rq_fair
All People I know including myself took a long time to figure out that typical wakeup will always go to fast path and never go to slow path except WF_FORK and WF_EXEC. Vincent reminded me once in a linaro meeting and made me understand slow path won't happen for WF_TTWU. But my other friends repeatedly wasted a lot of time on testing this path like me before I reminded them. So obviously the code needs some document. Signed-off-by: Barry Song <song.bao.hua@hisilicon.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20211016111109.5559-1-21cnbao@gmail.com
1 parent 014ba44 commit 2917406

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

kernel/sched/fair.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6917,6 +6917,11 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int wake_flags)
69176917
break;
69186918
}
69196919

6920+
/*
6921+
* Usually only true for WF_EXEC and WF_FORK, as sched_domains
6922+
* usually do not have SD_BALANCE_WAKE set. That means wakeup
6923+
* will usually go to the fast path.
6924+
*/
69206925
if (tmp->flags & sd_flag)
69216926
sd = tmp;
69226927
else if (!want_affine)

0 commit comments

Comments
 (0)