pinctrl: merrifield: Use BUFCFG_PINMODE_GPIO in ->pin_dbg_show()

andy-shev · andy-shev · commit 29cf9f36215c · 2023-06-06T16:07:33.000+03:00
Use explicit comparison to BUFCFG_PINMODE_GPIO instead of implying it.

Acked-by: Mika Westerberg &lt;mika.westerberg@linux.intel.com&gt;
Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
diff --git a/drivers/pinctrl/intel/pinctrl-merrifield.c b/drivers/pinctrl/intel/pinctrl-merrifield.c
@@ -549,7 +549,7 @@ static void mrfld_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
 	}
 
 	mode = (value & BUFCFG_PINMODE_MASK) >> BUFCFG_PINMODE_SHIFT;
-	if (!mode)
+	if (mode == BUFCFG_PINMODE_GPIO)
 		seq_puts(s, "GPIO ");
 	else
 		seq_printf(s, "mode %d ", mode);

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,7 @@ static void mrfld_pin_dbg_show(struct pinctrl_dev pctldev, struct seq_file s,`
`549`	`549`	`}`
`550`	`550`
`551`	`551`	`mode = (value & BUFCFG_PINMODE_MASK) >> BUFCFG_PINMODE_SHIFT;`
`552`		`- if (!mode)`
	`552`	`+ if (mode == BUFCFG_PINMODE_GPIO)`
`553`	`553`	`seq_puts(s, "GPIO ");`
`554`	`554`	`else`
`555`	`555`	`seq_printf(s, "mode %d ", mode);`