Skip to content

Commit 29ebf69

Browse files
z3ntudtor
authored andcommitted
Input: pwm-vibra - add newline to dev_err prints
Make sure all printed messages end with a newline. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> Reviewed-by: Brian Masney <bmasney@redhat.com> Reviewed-by: Sebastian Reichel <sre@kernel.org> Link: https://lore.kernel.org/r/20230427-hammerhead-vibra-v1-2-e87eeb94da51@z3ntu.xyz Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 54e6633 commit 29ebf69

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

drivers/input/misc/pwm-vibra.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator)
4242
if (!vibrator->vcc_on) {
4343
err = regulator_enable(vibrator->vcc);
4444
if (err) {
45-
dev_err(pdev, "failed to enable regulator: %d", err);
45+
dev_err(pdev, "failed to enable regulator: %d\n", err);
4646
return err;
4747
}
4848
vibrator->vcc_on = true;
@@ -54,7 +54,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator)
5454

5555
err = pwm_apply_state(vibrator->pwm, &state);
5656
if (err) {
57-
dev_err(pdev, "failed to apply pwm state: %d", err);
57+
dev_err(pdev, "failed to apply pwm state: %d\n", err);
5858
return err;
5959
}
6060

@@ -65,7 +65,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator)
6565

6666
err = pwm_apply_state(vibrator->pwm_dir, &state);
6767
if (err) {
68-
dev_err(pdev, "failed to apply dir-pwm state: %d", err);
68+
dev_err(pdev, "failed to apply dir-pwm state: %d\n", err);
6969
pwm_disable(vibrator->pwm);
7070
return err;
7171
}
@@ -137,7 +137,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
137137
err = PTR_ERR_OR_ZERO(vibrator->vcc);
138138
if (err) {
139139
if (err != -EPROBE_DEFER)
140-
dev_err(&pdev->dev, "Failed to request regulator: %d",
140+
dev_err(&pdev->dev, "Failed to request regulator: %d\n",
141141
err);
142142
return err;
143143
}
@@ -146,7 +146,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
146146
err = PTR_ERR_OR_ZERO(vibrator->pwm);
147147
if (err) {
148148
if (err != -EPROBE_DEFER)
149-
dev_err(&pdev->dev, "Failed to request main pwm: %d",
149+
dev_err(&pdev->dev, "Failed to request main pwm: %d\n",
150150
err);
151151
return err;
152152
}
@@ -158,7 +158,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
158158
state.enabled = false;
159159
err = pwm_apply_state(vibrator->pwm, &state);
160160
if (err) {
161-
dev_err(&pdev->dev, "failed to apply initial PWM state: %d",
161+
dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n",
162162
err);
163163
return err;
164164
}
@@ -172,7 +172,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
172172
state.enabled = false;
173173
err = pwm_apply_state(vibrator->pwm_dir, &state);
174174
if (err) {
175-
dev_err(&pdev->dev, "failed to apply initial PWM state: %d",
175+
dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n",
176176
err);
177177
return err;
178178
}
@@ -189,7 +189,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
189189
break;
190190

191191
default:
192-
dev_err(&pdev->dev, "Failed to request direction pwm: %d", err);
192+
dev_err(&pdev->dev, "Failed to request direction pwm: %d\n", err);
193193
fallthrough;
194194

195195
case -EPROBE_DEFER:
@@ -207,13 +207,13 @@ static int pwm_vibrator_probe(struct platform_device *pdev)
207207
err = input_ff_create_memless(vibrator->input, NULL,
208208
pwm_vibrator_play_effect);
209209
if (err) {
210-
dev_err(&pdev->dev, "Couldn't create FF dev: %d", err);
210+
dev_err(&pdev->dev, "Couldn't create FF dev: %d\n", err);
211211
return err;
212212
}
213213

214214
err = input_register_device(vibrator->input);
215215
if (err) {
216-
dev_err(&pdev->dev, "Couldn't register input dev: %d", err);
216+
dev_err(&pdev->dev, "Couldn't register input dev: %d\n", err);
217217
return err;
218218
}
219219

0 commit comments

Comments
 (0)